You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2021/07/22 12:53:07 UTC

[GitHub] [cxf] rmannibucau commented on a change in pull request #805: Make CDI and MP Config dependencies optional for MicroProfile REST client

rmannibucau commented on a change in pull request #805:
URL: https://github.com/apache/cxf/pull/805#discussion_r674767605



##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -134,15 +134,20 @@
         <dependency>
             <groupId>org.eclipse.microprofile.config</groupId>
             <artifactId>microprofile-config-api</artifactId>
+            <scope>provided</scope>

Review comment:
       True until you use either a plugin which uses only one or a scraper/lib/tool which reads the pom and only uses one.
   Strictly speaking (maven), provided means "will be there at compile time but not transitively", nothing more (rest is wording) and it was originally intended for specs (like here funnily) but optional was added (for OSGi I guess) to do the same so as of today, if the pom is consumed (and it is for CXF) I guess the best is to have both (minimal being provided which is the most supported one I guess?).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org