You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2014/02/21 18:47:01 UTC
Review Request 18361: Added hostname attribute to framework,
display it in master's web ui
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
- Added a field to FrameworkInfo in protobuf spec
- Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.
Diffs
-----
include/mesos/mesos.proto 69a4a60
include/mesos/scheduler.hpp 2e4707e
src/master/http.cpp c941274
src/sched/sched.cpp dcb3158
src/slave/http.cpp 7c4cfba
src/webui/master/static/frameworks.html 8686b00
Diff: https://reviews.apache.org/r/18361/diff/
Testing
-------
Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/#review35164
-----------------------------------------------------------
Ship it!
Ship It!
include/mesos/mesos.proto
<https://reviews.apache.org/r/18361/#comment65579>
remove the trailing whitespace please
- Dominic Hamon
On Feb. 21, 2014, 9:49 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18361/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 9:49 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Added a field to FrameworkInfo in protobuf spec
> - Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
> - Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
> - Refactored scheduler constructor so that code duplication is avoided.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 69a4a60
> include/mesos/scheduler.hpp 2e4707e
> src/master/http.cpp c941274
> src/sched/sched.cpp dcb3158
> src/slave/http.cpp 7c4cfba
> src/webui/master/static/frameworks.html 8686b00
>
> Diff: https://reviews.apache.org/r/18361/diff/
>
>
> Testing
> -------
>
> Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/#review35254
-----------------------------------------------------------
Attach the bug id to the RB's "Bug" field.
include/mesos/mesos.proto
<https://reviews.apache.org/r/18361/#comment65716>
Please wrap the comments by 70 chars.
include/mesos/mesos.proto
<https://reviews.apache.org/r/18361/#comment65717>
Lets do this in the similar vein of "user" field, i.e., only automagically set it if it's not set by the framework.
kill white space.
src/sched/sched.cpp
<https://reviews.apache.org/r/18361/#comment65718>
Only set this if the framework hasn't set it already.
src/sched/sched.cpp
<https://reviews.apache.org/r/18361/#comment65719>
New line.
- Vinod Kone
On Feb. 24, 2014, 4:11 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18361/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 4:11 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Added a field to FrameworkInfo in protobuf spec
> - Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
> - Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
> - Refactored scheduler constructor so that code duplication is avoided.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 69a4a60
> include/mesos/scheduler.hpp 2e4707e
> src/master/http.cpp c941274
> src/sched/sched.cpp dcb3158
> src/slave/http.cpp 7c4cfba
> src/webui/master/static/frameworks.html 8686b00
>
> Diff: https://reviews.apache.org/r/18361/diff/
>
>
> Testing
> -------
>
> Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/#review35298
-----------------------------------------------------------
Ship it!
Modulo Dominic's comments.
- Niklas Nielsen
On Feb. 24, 2014, 7:03 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18361/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 7:03 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Added a field to FrameworkInfo in protobuf spec
> - Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
> - Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
> - Refactored scheduler constructor so that code duplication is avoided.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 69a4a60
> include/mesos/scheduler.hpp 2e4707e
> src/master/http.cpp c941274
> src/sched/sched.cpp dcb3158
> src/slave/http.cpp 7c4cfba
> src/webui/master/static/frameworks.html 8686b00
>
> Diff: https://reviews.apache.org/r/18361/diff/
>
>
> Testing
> -------
>
> Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/#review35560
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 25, 2014, 2:16 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18361/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 2:16 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-945
> https://issues.apache.org/jira/browse/MESOS-945
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Added a field to FrameworkInfo in protobuf spec
> - Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
> - Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
> - Refactored scheduler constructor so that code duplication is avoided.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 69a4a60
> include/mesos/scheduler.hpp 2e4707e
> src/master/http.cpp c941274
> src/sched/sched.cpp dcb3158
> src/slave/http.cpp 7c4cfba
> src/webui/master/static/frameworks.html 8686b00
>
> Diff: https://reviews.apache.org/r/18361/diff/
>
>
> Testing
> -------
>
> Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------
(Updated Feb. 25, 2014, 6:16 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
got the wrong diff file before this one.
Bugs: MESOS-945
https://issues.apache.org/jira/browse/MESOS-945
Repository: mesos-git
Description
-------
- Added a field to FrameworkInfo in protobuf spec
- Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.
Diffs (updated)
-----
include/mesos/mesos.proto 69a4a60
include/mesos/scheduler.hpp 2e4707e
src/master/http.cpp c941274
src/sched/sched.cpp dcb3158
src/slave/http.cpp 7c4cfba
src/webui/master/static/frameworks.html 8686b00
Diff: https://reviews.apache.org/r/18361/diff/
Testing
-------
Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------
(Updated Feb. 25, 2014, 6:15 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Before anyone complains about a trailing blank in a comment line, I removed it (again, it snug back in).
Bugs: MESOS-945
https://issues.apache.org/jira/browse/MESOS-945
Repository: mesos-git
Description
-------
- Added a field to FrameworkInfo in protobuf spec
- Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/glog-0.3.3.patch 974f9f5
Diff: https://reviews.apache.org/r/18361/diff/
Testing
-------
Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------
(Updated Feb. 25, 2014, 6:12 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Hopefully this patch works better.
@Vinod: I cannot derive the hostname from the IP as in master/slave, because the scheduler does not have an IP handy. Maybe I can find the IP elsewhere? So far I suppose grabbing hostname from the OS is still the correct thing to do.
Bugs: MESOS-945
https://issues.apache.org/jira/browse/MESOS-945
Repository: mesos-git
Description
-------
- Added a field to FrameworkInfo in protobuf spec
- Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.
Diffs (updated)
-----
include/mesos/mesos.proto 69a4a60
include/mesos/scheduler.hpp 2e4707e
src/master/http.cpp c941274
src/sched/sched.cpp dcb3158
src/slave/http.cpp 7c4cfba
src/webui/master/static/frameworks.html 8686b00
Diff: https://reviews.apache.org/r/18361/diff/
Testing
-------
Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/#review35306
-----------------------------------------------------------
Bad diff? I can't seem to view the "sched.cpp" diff.
Error: The patch to 'src/sched/sched.cpp' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.RGkfVR' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.RGkfVR/tmpC62oNK Hunk #2 FAILED at 1070. 1 out of 4 hunks FAILED -- saving rejects to file /tmp/reviewboard.RGkfVR/tmpC62oNK-new.rej
Also, I forgot to mention it in my last review, but can you deduce the default hostname based on the libprocess ip address instead of os::hostname()? That would be consistent with how we deduced the default hostname in master and slave.
- Vinod Kone
On Feb. 24, 2014, 5:24 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18361/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 5:24 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-945
> https://issues.apache.org/jira/browse/MESOS-945
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Added a field to FrameworkInfo in protobuf spec
> - Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
> - Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
> - Refactored scheduler constructor so that code duplication is avoided.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 69a4a60
> include/mesos/scheduler.hpp 2e4707e
> src/master/http.cpp c941274
> src/sched/sched.cpp dcb3158
> src/slave/http.cpp 7c4cfba
> src/webui/master/static/frameworks.html 8686b00
>
> Diff: https://reviews.apache.org/r/18361/diff/
>
>
> Testing
> -------
>
> Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 9:24 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Addressed review issues.
Bugs: MESOS-945
https://issues.apache.org/jira/browse/MESOS-945
Repository: mesos-git
Description
-------
- Added a field to FrameworkInfo in protobuf spec
- Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.
Diffs (updated)
-----
include/mesos/mesos.proto 69a4a60
include/mesos/scheduler.hpp 2e4707e
src/master/http.cpp c941274
src/sched/sched.cpp dcb3158
src/slave/http.cpp 7c4cfba
src/webui/master/static/frameworks.html 8686b00
Diff: https://reviews.apache.org/r/18361/diff/
Testing
-------
Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/#review35291
-----------------------------------------------------------
include/mesos/mesos.proto
<https://reviews.apache.org/r/18361/#comment65752>
remove the blank space at end of line please
src/sched/sched.cpp
<https://reviews.apache.org/r/18361/#comment65755>
FrameworkInfo - the w is lowercase
src/sched/sched.cpp
<https://reviews.apache.org/r/18361/#comment65754>
if (framework.user().empty()) {
...
}
is better. Same for hostname below.
- Dominic Hamon
On Feb. 24, 2014, 7:03 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18361/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 7:03 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Added a field to FrameworkInfo in protobuf spec
> - Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
> - Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
> - Refactored scheduler constructor so that code duplication is avoided.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 69a4a60
> include/mesos/scheduler.hpp 2e4707e
> src/master/http.cpp c941274
> src/sched/sched.cpp dcb3158
> src/slave/http.cpp 7c4cfba
> src/webui/master/static/frameworks.html 8686b00
>
> Diff: https://reviews.apache.org/r/18361/diff/
>
>
> Testing
> -------
>
> Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 7:03 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Fixed review issues.
Repository: mesos-git
Description
-------
- Added a field to FrameworkInfo in protobuf spec
- Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.
Diffs (updated)
-----
include/mesos/mesos.proto 69a4a60
include/mesos/scheduler.hpp 2e4707e
src/master/http.cpp c941274
src/sched/sched.cpp dcb3158
src/slave/http.cpp 7c4cfba
src/webui/master/static/frameworks.html 8686b00
Diff: https://reviews.apache.org/r/18361/diff/
Testing
-------
Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 4:11 a.m.)
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
- Added a field to FrameworkInfo in protobuf spec
- Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.
Diffs
-----
include/mesos/mesos.proto 69a4a60
include/mesos/scheduler.hpp 2e4707e
src/master/http.cpp c941274
src/sched/sched.cpp dcb3158
src/slave/http.cpp 7c4cfba
src/webui/master/static/frameworks.html 8686b00
Diff: https://reviews.apache.org/r/18361/diff/
Testing
-------
Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
Thanks,
Bernd Mathiske
Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to
framework, display it in master's web ui
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 9:49 a.m.)
Review request for mesos.
Changes
-------
Mentioned JIRA topic in title.
Summary (updated)
-----------------
Implemented MESOS-945: Added hostname attribute to framework, display it in master's web ui
Repository: mesos-git
Description
-------
- Added a field to FrameworkInfo in protobuf spec
- Added table fields in html of web ui that display framework's hostname for running and terminated frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.
Diffs
-----
include/mesos/mesos.proto 69a4a60
include/mesos/scheduler.hpp 2e4707e
src/master/http.cpp c941274
src/sched/sched.cpp dcb3158
src/slave/http.cpp 7c4cfba
src/webui/master/static/frameworks.html 8686b00
Diff: https://reviews.apache.org/r/18361/diff/
Testing
-------
Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.
Thanks,
Bernd Mathiske