You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/24 15:35:22 UTC

[GitHub] [incubator-kvrocks] tanruixiang commented on issue #983: Flaky test on expire precision

tanruixiang commented on issue #983:
URL: https://github.com/apache/incubator-kvrocks/issues/983#issuecomment-1289220603

   > Holdon, I think here is another problem in `ParseTTL`, which would cause this problem, after go through the code of `ParseTTL` in `redis_cmd.cc`, I found that:
   > 
   > 1. `expire` is rounded to `seconds`
   > 2. `now` is also rounded to `seconds`
   > 
   > And assume that:
   > 
   > ```
   > now: 10.99s
   > expire: 21.01s
   > expected: 10.02s -> 10s ( bias for 20ms between clock maybe ok )
   > currently: 11s
   > ```
   > 
   > @git-hulk
   
   Our failing test case (Like `Extended SET EXAT option`) uses an expiration time in seconds, which doesn't seem to be a problem due to rounding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org