You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/08 09:53:39 UTC
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1971: feat: form added for request id
iamayushdas opened a new pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
added form for **request id** plugin
**Related issues**
fix/resolve #0001
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876317638
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1971](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (535d26e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4612d02a9c8e50abf13836e4f66ea56e1ab2e145?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4612d02) will **decrease** coverage by `2.93%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1971 +/- ##
==========================================
- Coverage 66.89% 63.95% -2.94%
==========================================
Files 179 123 -56
Lines 6551 3160 -3391
Branches 753 754 +1
==========================================
- Hits 4382 2021 -2361
+ Misses 1899 1139 -760
+ Partials 270 0 -270
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `63.95% <42.85%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `76.00% <33.33%> (-6.61%)` | :arrow_down: |
| [web/src/components/Plugin/UI/request-id.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZXF1ZXN0LWlkLnRzeA==) | `50.00% <50.00%> (ø)` | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | | |
| [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | | |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | |
| [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | |
| [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | |
| ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4612d02...535d26e](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876317638
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1971](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81243d1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5198854d5dc47f5181326e469d2e1bd86234a978?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5198854) will **decrease** coverage by `0.06%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1971 +/- ##
==========================================
- Coverage 65.74% 65.67% -0.07%
==========================================
Files 121 122 +1
Lines 3202 3208 +6
Branches 776 777 +1
==========================================
+ Hits 2105 2107 +2
- Misses 1097 1101 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `65.67% <42.85%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `76.92% <33.33%> (-6.42%)` | :arrow_down: |
| [web/src/components/Plugin/UI/request-id.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZXF1ZXN0LWlkLnRzeA==) | `50.00% <50.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5198854...81243d1](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#discussion_r666913280
##########
File path: web/src/components/Plugin/UI/request-id.tsx
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Form, Input, Switch } from 'antd';
+import { useIntl } from 'umi';
+
+type Props = {
+ form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+ labelCol: {
+ span: 7,
+ },
+ wrapperCol: {
+ span: 18
+ },
+};
+
+const RequestId: React.FC<Props> = ({ form }) => {
+ const { formatMessage } = useIntl();
+ return (
+ <Form
+ form={form}
+ {...FORM_ITEM_LAYOUT}
+ >
+ <Form.Item
+ label="header_name"
+ name="header_name"
+ initialValue="X-Request-Id"
+ rules={[{
+ required: false,
Review comment:
The default is false, and it can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-877101294
also cc @guoqqqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-877605575
> Hi, @iamayushdas can you add a test case for this PR?
Yes i will file a PR after making a set of forms, like for example - when i will create all the forms based on security then i will be making tests for each. Do you agree with me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#discussion_r667315919
##########
File path: web/src/components/Plugin/UI/request-id.tsx
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Form, Input, Switch } from 'antd';
+import { useIntl } from 'umi';
+
+type Props = {
+ form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+ labelCol: {
+ span: 7,
+ },
+ wrapperCol: {
+ span: 18
+ },
+};
+
+const RequestId: React.FC<Props> = ({ form }) => {
+ const { formatMessage } = useIntl();
+ return (
+ <Form
+ form={form}
+ {...FORM_ITEM_LAYOUT}
+ >
+ <Form.Item
+ label="header_name"
+ name="header_name"
+ initialValue="X-Request-Id"
+ rules={[{
+ message: `${formatMessage({ id: 'component.global.pleaseEnter' })} header_name`
+ }]}
+ tooltip={formatMessage({ id: 'component.pluginForm.request-id.heade_name.tooltip' })}
Review comment:
```suggestion
tooltip={formatMessage({ id: 'component.pluginForm.request-id.header_name.tooltip' })}
```
##########
File path: web/src/components/Plugin/locales/en-US.ts
##########
@@ -89,4 +89,8 @@ export default {
'component.pluginForm.limit-count.redis_cluster_nodes.tooltip': 'When using redis-cluster policy，This property is a list of addresses of Redis cluster service nodes (at least two nodes).',
'component.pluginForm.limit-count.redis_cluster_name.tooltip': 'When using redis-cluster policy, this property is the name of Redis cluster service nodes.',
'component.pluginForm.limit-count.atLeast2Characters.rule': 'Please enter at least 2 characters',
+
+ // request-id
+ 'component.pluginForm.request-id.header_name.tooltip': 'Request ID header name',
Review comment:
Please keep the key consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: f5f1498721d72ad2965e04fa6a48b8f5daaa5eeb
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6116249553c9c60008f971ac](https://app.netlify.com/sites/apisix-dashboard/deploys/6116249553c9c60008f971ac?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#discussion_r666914599
##########
File path: web/src/components/Plugin/UI/request-id.tsx
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Form, Input, Switch } from 'antd';
+import { useIntl } from 'umi';
+
+type Props = {
+ form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+ labelCol: {
+ span: 7,
+ },
+ wrapperCol: {
+ span: 18
+ },
+};
+
+const RequestId: React.FC<Props> = ({ form }) => {
+ const { formatMessage } = useIntl();
+ return (
+ <Form
+ form={form}
+ {...FORM_ITEM_LAYOUT}
+ >
+ <Form.Item
+ label="header_name"
+ name="header_name"
+ initialValue="X-Request-Id"
+ rules={[{
+ required: false,
Review comment:
👍🏻 okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876317638
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1971](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a8ebee) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/3cfc32761122ad7f15f67edcfc251d0bed2e7538?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cfc327) will **decrease** coverage by `2.90%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1971 +/- ##
==========================================
- Coverage 66.79% 63.89% -2.91%
==========================================
Files 182 123 -59
Lines 6575 3160 -3415
Branches 753 754 +1
==========================================
- Hits 4392 2019 -2373
+ Misses 1907 1141 -766
+ Partials 276 0 -276
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `63.89% <42.85%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `76.00% <33.33%> (-6.61%)` | :arrow_down: |
| [web/src/components/Plugin/UI/request-id.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZXF1ZXN0LWlkLnRzeA==) | `50.00% <50.00%> (ø)` | |
| [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | | |
| [api/cmd/install.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9pbnN0YWxsLmdv) | | |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | |
| [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | | |
| [api/cmd/start.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGFydC5nbw==) | | |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | |
| [api/cmd/stop.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdG9wLmdv) | | |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | |
| ... and [53 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3cfc327...4a8ebee](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
:heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
:hammer: Explore the source changes: 4a8ebee4a5b69954fa3301cf068ba642fec452f1
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e90ddd9227fc00078a37ce](https://app.netlify.com/sites/apisix-dashboard/deploys/60e90ddd9227fc00078a37ce?utm_source=github&utm_campaign=bot_dl)
:sunglasses: Browse the preview: [https://deploy-preview-1971--apisix-dashboard.netlify.app/](https://deploy-preview-1971--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-891493176
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: bcc5cc8e1f084b7f04d1256d3f9c1734142fd9c4
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610f007cb5095f00071d3f40](https://app.netlify.com/sites/apisix-dashboard/deploys/610f007cb5095f00071d3f40?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-1971--apisix-dashboard.netlify.app/](https://deploy-preview-1971--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
:heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
:hammer: Explore the source changes: 535d26e9361b703ad68f3532a966074fc7fe78f4
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e6cb17986ebd0007b2dd92](https://app.netlify.com/sites/apisix-dashboard/deploys/60e6cb17986ebd0007b2dd92?utm_source=github&utm_campaign=bot_dl)
:sunglasses: Browse the preview: [https://deploy-preview-1971--apisix-dashboard.netlify.app/](https://deploy-preview-1971--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-877546514
@guoqqqi have a look again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876317638
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1971](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90e0bed) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65c7246623fa992755674a5c214fbacaf9293904?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65c7246) will **decrease** coverage by `2.70%`.
> The diff coverage is `42.85%`.
> :exclamation: Current head 90e0bed differs from pull request most recent head f5f1498. Consider uploading reports for the commit f5f1498 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1971 +/- ##
==========================================
- Coverage 68.82% 66.12% -2.71%
==========================================
Files 181 122 -59
Lines 7005 3232 -3773
Branches 787 788 +1
==========================================
- Hits 4821 2137 -2684
+ Misses 1900 1095 -805
+ Partials 284 0 -284
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `66.12% <42.85%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `76.92% <33.33%> (-6.42%)` | :arrow_down: |
| [web/src/components/Plugin/UI/request-id.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZXF1ZXN0LWlkLnRzeA==) | `50.00% <50.00%> (ø)` | |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | | |
| [api/cmd/install.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9pbnN0YWxsLmdv) | | |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | |
| [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | | |
| [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | | |
| [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | |
| [api/cmd/start.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGFydC5nbw==) | | |
| ... and [53 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [65c7246...f5f1498](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876317638
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1971](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7fd5ff) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/3cfc32761122ad7f15f67edcfc251d0bed2e7538?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cfc327) will **decrease** coverage by `2.81%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1971 +/- ##
==========================================
- Coverage 66.79% 63.97% -2.82%
==========================================
Files 182 122 -60
Lines 6575 3162 -3413
Branches 753 754 +1
==========================================
- Hits 4392 2023 -2369
+ Misses 1907 1139 -768
+ Partials 276 0 -276
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `63.97% <50.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `76.00% <50.00%> (-6.61%)` | :arrow_down: |
| [web/src/components/Plugin/UI/request-id.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZXF1ZXN0LWlkLnRzeA==) | `50.00% <50.00%> (ø)` | |
| [web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=) | `83.33% <0.00%> (-3.34%)` | :arrow_down: |
| [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `76.08% <0.00%> (ø)` | |
| [web/src/components/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9zZXJ2aWNlLnRz) | `96.15% <0.00%> (ø)` | |
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <0.00%> (ø)` | |
| [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <0.00%> (ø)` | |
| [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <0.00%> (ø)` | |
| [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | | |
| ... and [63 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1971/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3cfc327...d7fd5ff](https://codecov.io/gh/apache/apisix-dashboard/pull/1971?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: d7fd5ff987150a768c36432bc582eedf9f65a3e1
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61093155c8aca200072898f0](https://app.netlify.com/sites/apisix-dashboard/deploys/61093155c8aca200072898f0?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-891483243
cc @liuxiran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
:construction_worker: Deploy Preview for *apisix-dashboard* processing.
:hammer: Explore the source changes: 4a8ebee4a5b69954fa3301cf068ba642fec452f1
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e90ddd9227fc00078a37ce](https://app.netlify.com/sites/apisix-dashboard/deploys/60e90ddd9227fc00078a37ce?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: 81243d18df458b4bcf3da4264a267988880b6725
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610f40eaf7e41400081f78c5](https://app.netlify.com/sites/apisix-dashboard/deploys/610f40eaf7e41400081f78c5?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: f5f1498721d72ad2965e04fa6a48b8f5daaa5eeb
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6116249553c9c60008f971ac](https://app.netlify.com/sites/apisix-dashboard/deploys/6116249553c9c60008f971ac?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-1971--apisix-dashboard.netlify.app/](https://deploy-preview-1971--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-894712394
> I think we should add a corresponding test case for each PR that adds a new feature. I don't recommend waiting for 😳
Agree with @guoqqqi , in order to make sure current pr is available, please add the corresponding test cases when you have time @iamayushdas , and fix the conflict files first, thanks a lot.
Recommended test cases are:
1. configure the `request-id` plugin with form successfully
2. configure the `request-id` plugin with form which has already enabled with JSON/YAML successfully, and at the same time pay attention to the value of each form field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: 81243d18df458b4bcf3da4264a267988880b6725
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610f40eaf7e41400081f78c5](https://app.netlify.com/sites/apisix-dashboard/deploys/610f40eaf7e41400081f78c5?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-1971--apisix-dashboard.netlify.app/](https://deploy-preview-1971--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
:construction_worker: Deploy Preview for *apisix-dashboard* processing.
:hammer: Explore the source changes: 535d26e9361b703ad68f3532a966074fc7fe78f4
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e6cb17986ebd0007b2dd92](https://app.netlify.com/sites/apisix-dashboard/deploys/60e6cb17986ebd0007b2dd92?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: bcc5cc8e1f084b7f04d1256d3f9c1734142fd9c4
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610f007cb5095f00071d3f40](https://app.netlify.com/sites/apisix-dashboard/deploys/610f007cb5095f00071d3f40?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-877616475
👍🏻 ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-891492884
@iamayushdas Hi, please sync with the master branch 🤔 Not sure if the CI failed due to that reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-877606346
But I think we can wait until everyone has confirmed that the PR is OK before you add a test case for it. 😊😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876300914
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: d7fd5ff987150a768c36432bc582eedf9f65a3e1
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61093155c8aca200072898f0](https://app.netlify.com/sites/apisix-dashboard/deploys/61093155c8aca200072898f0?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-1971--apisix-dashboard.netlify.app/](https://deploy-preview-1971--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#discussion_r666914486
##########
File path: web/src/components/Plugin/UI/request-id.tsx
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Form, Input, Switch } from 'antd';
+import { useIntl } from 'umi';
+
+type Props = {
+ form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+ labelCol: {
+ span: 7,
+ },
+ wrapperCol: {
+ span: 18
+ },
+};
+
+const RequestId: React.FC<Props> = ({ form }) => {
+ const { formatMessage } = useIntl();
+ return (
+ <Form
+ form={form}
+ {...FORM_ITEM_LAYOUT}
+ >
+ <Form.Item
+ label="header_name"
+ name="header_name"
+ initialValue="X-Request-Id"
+ rules={[{
+ required: false,
+ message: `${formatMessage({ id: 'component.global.pleaseEnter' })} header_name`
+ }]}
+ tooltip={formatMessage({ id: 'component.pluginForm.request-id.heade_name.tooltip' })}
+ validateTrigger={['onChange', 'onBlur', 'onClick']}
+ >
+ <Input />
+ </Form.Item>
+ <Form.Item
+ label="include_in_response"
+ name="include_in_response"
+ rules={[{
+ required: false,
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-877606059
I think we should add a corresponding test case for each PR that adds a new feature. I don't recommend waiting for 😳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-876301778
cc @juzhiyuan @liuxiran @guoqqqi @LiteSun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-877605238
Hi, @iamayushdas can you add a test case for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-894723969
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1971: feat: form added for request id
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1971:
URL: https://github.com/apache/apisix-dashboard/pull/1971#issuecomment-877150120
> also cc @guoqqqi
Already did 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org