You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/10 01:44:12 UTC

[GitHub] [calcite] cshuo commented on issue #1738: [CALCITE-3719] Add hint option checker to customize the option

cshuo commented on issue #1738: [CALCITE-3719] Add hint option checker to customize the option
URL: https://github.com/apache/calcite/pull/1738#issuecomment-572835917
 
 
   > > Hi, Danny, LGTM overall.
   > > And just some thoughts, IMO, hint strategy is some kind of a `validation`, so I'm wondering if we can squash these two interface into one?
   > 
   > I would rather keep the 2 interfaces for 3 reasons:
   > 
   > 1. Now the `HintStrategy` can be used to multiple hints, i.e. the `NodeTypeHintStrategy`, but the `HintOptionChecker` is always used to a specific hint
   > 2. The `HintOptionChecker` is optional
   > 3. They can be used as functional interface, write as lambda `(rel, hint) ->`
   
   make sense.  😃

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services