You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Craig Russell (JIRA)" <ji...@apache.org> on 2006/01/13 20:36:20 UTC

[jira] Created: (JDO-277) Change wage in PartTimeEmployee instances to a small number

Change wage in PartTimeEmployee instances to a small number
-----------------------------------------------------------

         Key: JDO-277
         URL: http://issues.apache.org/jira/browse/JDO-277
     Project: JDO
        Type: Improvement
  Components: tck20  
    Reporter: Craig Russell
    Priority: Trivial
     Fix For: JDO 2 beta


The test data for PartTimeEmployee includes wage of 13000 and 15000. This test data has been confused with the salary of FullTimeEmployee. I propose changing the test data for PartTimeEmployee wage from 15000 to 15 and from 13000 to 13.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (JDO-277) Change wage in PartTimeEmployee instances to a small number

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-277?page=all ]
     
Craig Russell resolved JDO-277:
-------------------------------

    Resolution: Fixed
     Assign To: Craig Russell

Committed revision 368922.


> Change wage in PartTimeEmployee instances to a small number
> -----------------------------------------------------------
>
>          Key: JDO-277
>          URL: http://issues.apache.org/jira/browse/JDO-277
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Reporter: Craig Russell
>     Assignee: Craig Russell
>     Priority: Trivial
>      Fix For: JDO 2 beta
>  Attachments: parttimeemployee.patch, parttimeemployee.patch
>
> The test data for PartTimeEmployee includes wage of 13000 and 15000. This test data has been confused with the salary of FullTimeEmployee. I propose changing the test data for PartTimeEmployee wage from 15000 to 15 and from 13000 to 13.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JDO-277) Change wage in PartTimeEmployee instances to a small number

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-277?page=all ]

Craig Russell updated JDO-277:
------------------------------

    Attachment: parttimeemployee.patch

This patch changes all of the test/testdata files that use PartTimeEmployee, per Michael's comments.

> Change wage in PartTimeEmployee instances to a small number
> -----------------------------------------------------------
>
>          Key: JDO-277
>          URL: http://issues.apache.org/jira/browse/JDO-277
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Reporter: Craig Russell
>     Priority: Trivial
>      Fix For: JDO 2 beta
>  Attachments: parttimeemployee.patch, parttimeemployee.patch
>
> The test data for PartTimeEmployee includes wage of 13000 and 15000. This test data has been confused with the salary of FullTimeEmployee. I propose changing the test data for PartTimeEmployee wage from 15000 to 15 and from 13000 to 13.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JDO-277) Change wage in PartTimeEmployee instances to a small number

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-277?page=all ]

Craig Russell updated JDO-277:
------------------------------

    Attachment: parttimeemployee.patch

This patch changes the test data to reasonable "wage" from 15000 to 15 and from 13000 to 13.

No effect on test execution with this patch.

> Change wage in PartTimeEmployee instances to a small number
> -----------------------------------------------------------
>
>          Key: JDO-277
>          URL: http://issues.apache.org/jira/browse/JDO-277
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Reporter: Craig Russell
>     Priority: Trivial
>      Fix For: JDO 2 beta
>  Attachments: parttimeemployee.patch
>
> The test data for PartTimeEmployee includes wage of 13000 and 15000. This test data has been confused with the salary of FullTimeEmployee. I propose changing the test data for PartTimeEmployee wage from 15000 to 15 and from 13000 to 13.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (JDO-277) Change wage in PartTimeEmployee instances to a small number

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JDO-277?page=comments#action_12362681 ] 

Michael Bouschen commented on JDO-277:
--------------------------------------

The patch looks good. You might want to take a look at the other company model test data xml files, because they might define the same values for the wage. I'm not sure whether there are any tests explictly using these values. If so, they need to be updated, too. 

> Change wage in PartTimeEmployee instances to a small number
> -----------------------------------------------------------
>
>          Key: JDO-277
>          URL: http://issues.apache.org/jira/browse/JDO-277
>      Project: JDO
>         Type: Improvement
>   Components: tck20
>     Reporter: Craig Russell
>     Priority: Trivial
>      Fix For: JDO 2 beta
>  Attachments: parttimeemployee.patch
>
> The test data for PartTimeEmployee includes wage of 13000 and 15000. This test data has been confused with the salary of FullTimeEmployee. I propose changing the test data for PartTimeEmployee wage from 15000 to 15 and from 13000 to 13.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira