You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/06/14 17:07:18 UTC
[GitHub] [brooklyn-ui] iuliana opened a new pull request #223: Added fix for catalog 'edit in' links
iuliana opened a new pull request #223:
URL: https://github.com/apache/brooklyn-ui/pull/223
Edit with YAML editor and Graphical editor now work for multiple yaml plan formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana commented on pull request #223: Added fix for catalog 'edit in' links
Posted by GitBox <gi...@apache.org>.
iuliana commented on pull request #223:
URL: https://github.com/apache/brooklyn-ui/pull/223#issuecomment-861304276
> Looks ok, however, I would check the following condition:
>
> ```
> if(Array.isArray(edit.type.specList) && edit.type.specList.length > 0 && edit.type.specList[0].format === $stateParams.format) {
> yaml = edit.type.specList[0].contents;
> }
> ```
>
> `Array.isArray()` verifies if it is not null as well.
@algairim you're the JavaScript expert. Updated as requested. Cheers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #223: Added fix for catalog 'edit in' links
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #223:
URL: https://github.com/apache/brooklyn-ui/pull/223#issuecomment-860850619
Looks ok, however, I would check the following condition:
```
if(Array.isArray(edit.type.specList) && edit.type.specList.length > 0 && edit.type.specList[0].format === $stateParams.format) {
yaml = edit.type.specList[0].contents;
}
```
`Array.isArray()` verifies if it is not null as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #223: Added fix for catalog 'edit in' links
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #223:
URL: https://github.com/apache/brooklyn-ui/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org