You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jg...@apache.org on 2015/04/23 01:38:58 UTC
tomee git commit: PMD fixes
Repository: tomee
Updated Branches:
refs/heads/tomee-1.7.x 037cb47fb -> 558760138
PMD fixes
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/55876013
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/55876013
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/55876013
Branch: refs/heads/tomee-1.7.x
Commit: 5587601384b2d5b83d282cc2b7de7d276846e739
Parents: 037cb47
Author: Jonathan Gallimore <jo...@jrg.me.uk>
Authored: Thu Apr 23 00:37:48 2015 +0100
Committer: Jonathan Gallimore <jo...@jrg.me.uk>
Committed: Thu Apr 23 00:37:48 2015 +0100
----------------------------------------------------------------------
.../java/org/apache/openejb/assembler/classic/Assembler.java | 7 -------
1 file changed, 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tomee/blob/55876013/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
index 9e7e0a3..4b966f8 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
@@ -971,7 +971,6 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
try {
thread.setContextClassLoader(classLoader);
- final Set<String> resourceIds = new HashSet<String>(inResourceIds);
final List<ResourceInfo> resourceList = config.facilities.resources;
for (final ResourceInfo resourceInfo : resourceList) {
@@ -1662,8 +1661,6 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
private void destroyResource(final String name, final String className, final Object object) {
- Collection<Method> preDestroy = null;
-
if (object instanceof ResourceAdapterReference) {
final ResourceAdapterReference resourceAdapter = (ResourceAdapterReference) object;
try {
@@ -3012,10 +3009,6 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
parentLogger.getChildLogger("service").warning("unusedProperty", property, id);
}
- private static void unusedProperty(final String id, final String property) {
- unusedProperty(id, SystemInstance.get().getComponent(Assembler.class).logger, property);
- }
-
public static ObjectRecipe prepareRecipe(final ServiceInfo info) {
final String[] constructorArgs = info.constructorArgs.toArray(new String[info.constructorArgs.size()]);
final ObjectRecipe serviceRecipe = new ObjectRecipe(info.className, info.factoryMethod, constructorArgs, null);