[jira] [Commented] (AIRFLOW-3639) Jenkins Operator does not set up "Authorization" header correctly

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735184#comment-16735184 ] 

ASF GitHub Bot commented on AIRFLOW-3639:
-----------------------------------------

vapiravfif commented on pull request #4450: [AIRFLOW-3639] Fix request creation in Jenkins Operator
URL: https://github.com/apache/airflow/pull/4450
 
 
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3639
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Change Jenkins Operator to work with native Jenkins library method to configure REST request headers correctly
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Uses original operator's tests
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Jenkins Operator does not set up "Authorization" header correctly
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-3639
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3639
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib, operators
>    Affects Versions: 1.10.1
>            Reporter: Maria Rebelka
>            Assignee: Maria Rebelka
>            Priority: Major
>
> When working with Jenkins with security enabled, auth header is missing and Jenkins rejects the request.
> In Jenkins operator, function jenkins_request_with_headers creates request manually, and authentication mechanism against Jenkins server never initialised, resulting jenkins_server.auth being 'None'.
> {code:python}
> if jenkins_server.auth:
>             req.add_header('Authorization', jenkins_server.auth)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)