[GitHub] [apisix] Fabriceli commented on a diff in pull request #9301: fix(ssl): ssl label upgrade max len

["Fabriceli (via GitHub)" <gi...@apache.org>]

Fabriceli commented on code in PR #9301:
URL: https://github.com/apache/apisix/pull/9301#discussion_r1172798955


##########
t/admin/ssl4.t:
##########
@@ -364,3 +364,40 @@ location /t {
         t.test('/apisix/admin/ssls/1', ngx.HTTP_DELETE)
     }
 }
+
+
+=== TEST 11: set ssl(sni: www.test.com) with long label
+--- yaml_config
+apisix:
+    node_listen: 1984
+    ssl:
+        key_encrypt_salt: null
+--- config
+location /t {
+    content_by_lua_block {
+        local core = require("apisix.core")
+        local t = require("lib.test_admin")
+
+        local ssl_cert = t.read_file("t/certs/apisix.crt")
+        local ssl_key =  t.read_file("t/certs/apisix.key")
+        local data = {cert = ssl_cert, key = ssl_key, sni = "www.test.com",
+         labels = {"secret-name": "js-design-test-bigdata-data-app-service-router-my-secret-number-123456"}}

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org