You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2023/11/23 05:28:52 UTC

Re: [PR] fix: Add all Trino dependencies for Kerberos enablement [superset]

villebro commented on code in PR #26077:
URL: https://github.com/apache/superset/pull/26077#discussion_r1402928784


##########
requirements/base.txt:
##########
@@ -371,6 +369,7 @@ werkzeug==2.3.3
     # via
     #   apache-superset
     #   flask
+    #   flask-appbuilder

Review Comment:
   I think we need to add a CI linting rule to make sure the requirements files are always up to date (I assume this change didn't bring about this change). Any objections to me adding a step to the python lint CI workflow that does this in a separate PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org