You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2015/03/25 10:54:08 UTC
[GitHub] storm pull request: [storm-redis] Remove unused and buggy feature
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/482
[storm-redis] Remove unused and buggy feature
@dashengju and me decided to remove RedisStateSetUpdater / RedisStateSetCountQuerier because it didn't documented, didn't have any test cases, and have bugs.
We can introduce counter / various data types later.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-723
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/482.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #482
----
commit c75de7e7e63f282f44306d7bd0635a7a9be5e925
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-03-25T09:51:07Z
[storm-redis] Remove unused and buggy feature
* We can introduce counter / various data types later
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/482#issuecomment-86539867
OK, I'll merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/482#issuecomment-86526814
I think we should remove these 2 files from all branches, since we'll introduce new classes if we need.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/482#issuecomment-86542171
@HeartSaVioR yes, but this is a very easy cherry-pick, when we are depleting code. I am running the tests on 0.10.x-branch now to be sure everything looks good, and then I will merge it in and resolve the JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/482#issuecomment-86541464
@revans2 Thanks for merging! Especially I know that cherry-picking commits is not a easy way to do. ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/482#issuecomment-86521810
I am +1 on the change, but my only question is do we want to do this only for all branches? or only for 0.10.X?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...
Posted by dashengju <gi...@git.apache.org>.
Github user dashengju commented on the pull request:
https://github.com/apache/storm/pull/482#issuecomment-86293223
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---