[jira] (MEAR-170) EAR plugin will emit invalid application.xml (without needing user override)

["Darryl L. Miles (JIRA)" <ji...@codehaus.org>]

Darryl L. Miles created MEAR-170:
------------------------------------

             Summary: EAR plugin will emit invalid application.xml (without needing user override)
                 Key: MEAR-170
                 URL: https://jira.codehaus.org/browse/MEAR-170
             Project: Maven 2.x Ear Plugin
          Issue Type: Bug
    Affects Versions: 2.8
            Reporter: Darryl L. Miles


The DTD/XSD for the application.xml indicates that it must contain both a <display-name> and at least one <module> element.

Maven EAR plugin will emit <display-name> by default, this bug ticket has no concerns there.

But it is easy to configure it up with no valid <module>.


The plugin should have a new user-configurable attribute to enforce application.xml DTD/XSD rules.  It should be in enforcing mode by default (so the plugin will cause a build error if the configuration causes an invalid application.xml to be emitted).

When this situation is detected the user should be informed in the Maven error message that to override this check they can set -DenforceWellFormedApplicationXml=false



The above information may not be correct for all EE versions of application.xml so for each EE version the rule(s) should be checked.

But Maven by default should not be emitting invalid XML data, without the user overriding this check manually.


There is also a use case to allow not emitting an application.xml at all when there is no configuration (no <module> set).  However again this should not be the default, if the user is using the EAR plugin they expect it to produce a well formed EAR artifact (and provide assistance towards that goal, by displaying appropriate error messages when they do something wrong).  This means the default should be to always need to create an application.xml.  Which then means they must configure the maven-ear-plugin correctly to achieve that goal (and not get a build failure).






--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira