You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/11 20:53:20 UTC
[jira] [Work logged] (TS-4955) Remove the global mutex from the
plugin session acceptor.
[ https://issues.apache.org/jira/browse/TS-4955?focusedWorklogId=30433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30433 ]
ASF GitHub Bot logged work on TS-4955:
--------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/16 20:52
Start Date: 11/Oct/16 20:52
Worklog Time Spent: 10m
Work Description: GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1096
TS-4955: Remove the global mutex from the plugin session acceptor.
``plugin_http_accept`` has a global mutex which can be contended by protocol plugins. We don't require locking on ``HttpSessionAccept`` objects and the normal server port accept objects are not locked.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4955
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1096.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1096
----
commit 733c6113790fd5eb26492e1df3a14447118c6e40
Author: James Peach <jp...@apache.org>
Date: 2016-10-11T19:07:59Z
TS-4955: Assign the Plugin VC acceptor at allocation time.
Since we always require a continuation to receive the accept event,
just require it at allocation time, rather than requiring the caller to
remember to call an additional function.
commit c5906cae914787c4c6acf14f590a736b1eff9984
Author: James Peach <jp...@apache.org>
Date: 2016-10-11T20:44:42Z
TS-4955: Allow Plugin VC accept continuation to be unlocked.
We never need to hold the continuation lock when delivering
NET_EVENT_ACCEPT, so allow a NULL continuation mutex in PluginVC to
prevent lock contention on the plugin_http_accept object. We still hold
the lock if it is present since in the intercept cases, the continuation
can come from plugins that may be expecting us to lock.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 30433)
Time Spent: 10m
Remaining Estimate: 0h
> Remove the global mutex from the plugin session acceptor.
> ---------------------------------------------------------
>
> Key: TS-4955
> URL: https://issues.apache.org/jira/browse/TS-4955
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core, Performance
> Reporter: James Peach
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{plugin_http_accept}} has a global mutex which gets contended by protocol plugins. We don't require locking on {{HttpSessionAccept}} objects and the normal server port accept objects are not locked.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)