[jira] [Updated] (MINIFICPP-1662) fix gsl include

["Marton Szasz (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MINIFICPP-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marton Szasz updated MINIFICPP-1662:
------------------------------------
    Status: Patch Available  (was: In Progress)

https://github.com/apache/nifi-minifi-cpp/pull/1197

> fix gsl include
> ---------------
>
>                 Key: MINIFICPP-1662
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1662
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Marton Szasz
>            Assignee: Marton Szasz
>            Priority: Trivial
>
> gsl-lite recommends that libraries use it through the {{::gsl_lite}} namespace, possibly by a namespace alias in their own namespace. source and rationale: [https://github.com/gsl-lite/gsl-lite#using-gsl-lite-in-libraries]
> For this reason, I created {{"utils/gsl.h"}} with the intention of it being the common entry point from minifi to gsl, including a namespace alias of {{::org::apache::nifi::minifi::gsl}} to {{::gsl_lite}}. Please use the {{"utils/gsl.h"}} header and the {{gsl}} namespace alias instead of directly including {{"gsl/gsl-lite.hpp"}} and referring to {{::gsl}}.
> This issue is for submitting a PR that fixes the one occurrence where this is not followed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)