You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2022/09/06 16:18:52 UTC
[superset] branch john-bodley--connector-list-columns created (now ca577859db)
This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a change to branch john-bodley--connector-list-columns
in repository https://gitbox.apache.org/repos/asf/superset.git
at ca577859db chore(connector): Expose table_id as a listable column for SqlMetricInlineView and TableColumnInlineView classes
This branch includes the following new commits:
new ca577859db chore(connector): Expose table_id as a listable column for SqlMetricInlineView and TableColumnInlineView classes
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: chore(connector): Expose table_id as a listable column for SqlMetricInlineView and TableColumnInlineView classes
Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a commit to branch john-bodley--connector-list-columns
in repository https://gitbox.apache.org/repos/asf/superset.git
commit ca577859dbcecde03fbc5974fcfd5323ee2bf091
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Tue Sep 6 09:18:41 2022 -0700
chore(connector): Expose table_id as a listable column for SqlMetricInlineView and TableColumnInlineView classes
---
superset/connectors/sqla/views.py | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py
index 7133cdfab9..08a302257b 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -93,14 +93,15 @@ class TableColumnInlineView( # pylint: disable=too-many-ancestors
]
add_columns = edit_columns
list_columns = [
- "column_name",
- "verbose_name",
- "type",
"advanced_data_type",
- "groupby",
+ "column_name",
+ "extra",
"filterable",
+ "groupby",
"is_dttm",
- "extra",
+ "table_id",
+ "type",
+ "verbose_name",
]
page_size = 500
description_columns = {
@@ -210,7 +211,13 @@ class SqlMetricInlineView( # pylint: disable=too-many-ancestors
add_title = _("Add Metric")
edit_title = _("Edit Metric")
- list_columns = ["metric_name", "verbose_name", "metric_type", "extra"]
+ list_columns = [
+ "extra",
+ "metric_name",
+ "metric_type",
+ "table_id",
+ "verbose_name",
+ ]
edit_columns = [
"metric_name",
"description",