You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/31 02:52:49 UTC
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1166: fix: update online debug api protocol validation and error msg
nic-chen commented on a change in pull request #1166:
URL: https://github.com/apache/apisix-dashboard/pull/1166#discussion_r550382253
##########
File path: api/internal/handler/route_online_debug/route_online_debug.go
##########
@@ -49,6 +49,7 @@ var protocolMap map[string]ProtocolSupport
func init() {
protocolMap = make(map[string]ProtocolSupport)
protocolMap["http"] = &HTTPProtocolSupport{}
+ protocolMap["https"] = &HTTPProtocolSupport{}
}
Review comment:
oh, we don't need a init function here, just a map is ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org