[GitHub] [ozone] Galsza commented on a diff in pull request #4816: HDDS-8744. Clean up checked functional interfaces

["Galsza (via GitHub)" <gi...@apache.org>]

Galsza commented on code in PR #4816:
URL: https://github.com/apache/ozone/pull/4816#discussion_r1213372467


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/TestCSMMetrics.java:
##########
@@ -132,10 +129,10 @@ static void runContainerStateMachineMetrics(
       assertCounter("WriteChunkMsNumOps", 0L, metric);
       double applyTransactionLatency = getDoubleGauge(
           "ApplyTransactionNsAvgTime", metric);
-      assertTrue(applyTransactionLatency == 0.0);
+      assertEquals(0.0, applyTransactionLatency, 0.0);

Review Comment:
   Wouldn't Math.ulp be better for epsilon here? What does 0.0 mean as the epsilon here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org