You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/26 07:21:15 UTC
[GitHub] [airflow] uranusjr commented on a change in pull request #19815: Amazon provider remove deprecation, second try
uranusjr commented on a change in pull request #19815:
URL: https://github.com/apache/airflow/pull/19815#discussion_r757275334
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -184,7 +184,13 @@ def get_iam_token(self, conn: Connection) -> Tuple[str, str, int]:
# Pull the custer-identifier from the beginning of the Redshift URL
# ex. my-cluster.ccdre4hpd39h.us-east-1.redshift.amazonaws.com returns my-cluster
cluster_identifier = conn.extra_dejson.get('cluster-identifier', conn.host.split('.')[0])
- client = aws_hook.get_client_type('redshift')
+ session, endpoint_url = aws_hook._get_credentials()
+ client = session.client(
+ "redshift",
+ endpoint_url=endpoint_url,
+ config=aws_hook.config,
+ verify=aws_hook.verify,
+ )
Review comment:
We can just tell the mock to return a tuple :) I’ll update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org