[GitHub] brodybits opened a new pull request #49: Package update WIP FOR DISCUSSION

[GitBox <gi...@apache.org>]

brodybits opened a new pull request #49: Package update WIP FOR DISCUSSION
URL: https://github.com/apache/cordova-osx/pull/49
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   macOS ("osx")
   
   ### What does this PR do?
   
   - remove `node_modules` from repo
   - drop `uncrustify` (does not appear to be needed)
   - migrate from jasmine-node to jasmine
   - upgrade the following dependencies & devDependencies:
     - `cordova-common`
     - `xcode`
     - `eslint`
     - `nodeunit`
   
   TBD/TODO: I suspect that the outdated `coffee-script` dependency is not needed and can be removed.
   
   ### What testing has been done on this change?
   
   - `npm test` passes on mac
   - `cordova run osx` working on new project created by `cordova create` and "osx" platform added by `cordova platform add https://github.com/brodybits/cordova-osx#cb-update-wip1`
   - passes the `cordova-sqlite-storage` test suite with `cordova-sqlite-storage` added by `cordova plugin add cordova-sqlite-storage` (using Xcode to run)
   
   ### Checklist
   
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.~~
   - ~~Added automated test coverage as appropriate for this change.~~
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org