You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/05/11 04:40:16 UTC
[GitHub] [dubbo-go-pixiu] maxingg opened a new pull request, #422: fix: modify tracing filter config method.
maxingg opened a new pull request, #422:
URL: https://github.com/apache/dubbo-go-pixiu/pull/422
**What this PR does**:
Update TraceFilterFactory's Config method, this should not return nil. In addition, resolve in samples doesn't need a tracing config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #422: fix: modify tracing filter config method.
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #422:
URL: https://github.com/apache/dubbo-go-pixiu/pull/422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a diff in pull request #422: fix: modify tracing filter config method.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #422:
URL: https://github.com/apache/dubbo-go-pixiu/pull/422#discussion_r870137892
##########
pkg/filter/tracing/tracing.go:
##########
@@ -29,7 +29,7 @@ import (
"github.com/apache/dubbo-go-pixiu/pkg/tracing"
)
-const jaegerTraceIDInHeader = "uber-trace-id"
+const TraceIDInHeader = "uber-trace-id"
Review Comment:
so, pls change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #422: fix: modify tracing filter config method.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #422:
URL: https://github.com/apache/dubbo-go-pixiu/pull/422#issuecomment-1123183083
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#422](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3204eef) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2b24d46eac4c7a9876b7304405b87b5ae77208b0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b24d46) will **increase** coverage by `0.96%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #422 +/- ##
===========================================
+ Coverage 36.61% 37.58% +0.96%
===========================================
Files 55 55
Lines 3654 3720 +66
===========================================
+ Hits 1338 1398 +60
- Misses 2164 2166 +2
- Partials 152 156 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/server/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9waXhpdV9zdGFydC5nbw==) | `3.22% <0.00%> (-0.23%)` | :arrow_down: |
| [pkg/server/listener\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lcl9tYW5hZ2VyLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `15.21% <0.00%> (ø)` | |
| [...oregistry/registry/zookeeper/interface\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvaW50ZXJmYWNlX2xpc3RlbmVyLmdv) | `10.00% <0.00%> (ø)` | |
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/config/xds/cds.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy94ZHMvY2RzLmdv) | `52.89% <0.00%> (+0.39%)` | :arrow_up: |
| [pkg/config/xds/lds.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy94ZHMvbGRzLmdv) | `58.03% <0.00%> (+51.78%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2b24d46...3204eef](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/422?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] maxingg commented on a diff in pull request #422: fix: modify tracing filter config method.
Posted by GitBox <gi...@apache.org>.
maxingg commented on code in PR #422:
URL: https://github.com/apache/dubbo-go-pixiu/pull/422#discussion_r869964048
##########
pkg/filter/tracing/tracing.go:
##########
@@ -29,7 +29,7 @@ import (
"github.com/apache/dubbo-go-pixiu/pkg/tracing"
)
-const jaegerTraceIDInHeader = "uber-trace-id"
+const TraceIDInHeader = "uber-trace-id"
Review Comment:
"uber-trace-id" is used by jaeger. Since we can support multiple exporters, "dubbo-go-trace-id" is better actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a diff in pull request #422: fix: modify tracing filter config method.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #422:
URL: https://github.com/apache/dubbo-go-pixiu/pull/422#discussion_r869868816
##########
pkg/filter/tracing/tracing.go:
##########
@@ -29,7 +29,7 @@ import (
"github.com/apache/dubbo-go-pixiu/pkg/tracing"
)
-const jaegerTraceIDInHeader = "uber-trace-id"
+const TraceIDInHeader = "uber-trace-id"
Review Comment:
change the value to "dubbo-go-trace-id"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on a diff in pull request #422: fix: modify tracing filter config method.
Posted by GitBox <gi...@apache.org>.
mark4z commented on code in PR #422:
URL: https://github.com/apache/dubbo-go-pixiu/pull/422#discussion_r870992617
##########
pkg/filter/tracing/tracing.go:
##########
@@ -29,7 +29,7 @@ import (
"github.com/apache/dubbo-go-pixiu/pkg/tracing"
)
-const jaegerTraceIDInHeader = "uber-trace-id"
+const TraceIDInHeader = "dubbo-go-trace-id"
Review Comment:
dubbo-go-pixiu-trace-id better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org