[GitHub] srowen closed pull request #23401: Trigger GC on executor node idle

[GitBox <gi...@apache.org>]

srowen closed pull request #23401: Trigger GC on executor node idle
URL: https://github.com/apache/spark/pull/23401
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/main/scala/org/apache/spark/executor/Executor.scala b/core/src/main/scala/org/apache/spark/executor/Executor.scala
index a30a501e5d4a1..85c241fa5fd90 100644
--- a/core/src/main/scala/org/apache/spark/executor/Executor.scala
+++ b/core/src/main/scala/org/apache/spark/executor/Executor.scala
@@ -628,6 +628,24 @@ private[spark] class Executor(
           }
       } finally {
         runningTasks.remove(taskId)
+        if(conf.getBoolean("spark.conf.GCOnIdle.enabled", false)) {
+          if (runningTasks.isEmpty) {
+            triggerGCOnIdle(conf.getInt("spark.conf.GCOnIdle.threshold", 80))
+          }
+        }
+      }
+    }
+
+    /**
+     * Trigger GC on executor wait for remaining tasks to finish.
+     *
+     */
+    private def triggerGCOnIdle(threshold: Int): Unit = {
+      var memoryMXBean = ManagementFactory.getMemoryMXBean
+      var percentUsed = memoryMXBean.getHeapMemoryUsage.getUsed * 100 /
+        memoryMXBean.getHeapMemoryUsage.getMax
+      if(percentUsed > threshold) {
+        memoryMXBean.gc()
       }
     }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org