You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/07/09 00:12:04 UTC
[jira] [Commented] (CB-7093) Port automated file tests to
plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055595#comment-14055595 ]
ASF GitHub Bot commented on CB-7093:
------------------------------------
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/60
CB-7093 Ported automated File tests for cordova-plugin-test-framework
Ported 131 File automated tests from mobilespec.
Jasmine version: ported from v1.3 to v2.0
Features:
-No spies.
-No timeouts.
-Tests failing faster, when a error callback or unexpected success callback is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which contains the operation and a description about it.
-Jasmine reports include error callback object.
-Code reduced and simplified.
Bugs:
Found problem described in the code at:
https://github.com/martincgg/cordova-plugin-file/blob/dcc34b628c9896084b886747308171e63f684270/test/tests.js#L2057
https://github.com/martincgg/cordova-plugin-file/blob/dcc34b628c9896084b886747308171e63f684270/test/tests.js#L2110
Issue related (file spec 85 & 92): CB-7095
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-plugin-file CB-7093
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/60.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #60
----
commit dcc34b628c9896084b886747308171e63f684270
Author: Martin Gonzalez <ma...@gmail.com>
Date: 2014-07-08T22:05:38Z
CB-7093 Ported automated file tests
Ported File plugin automated tests from mobilespec,
Jasmine version: ported from 1.3 to 2.0
Features:
-No spies.
-No timeouts.
-Tests fails faster, when a error callback or unexpected callback is
received the test fails imediately.
-Jasmine report with more information about the failed operation, which
contains the operation and a description about it.
-Jasmine reports include error callback object.
-Code reduced and simplified.
----
> Port automated file tests to plugin-test-framework
> --------------------------------------------------
>
> Key: CB-7093
> URL: https://issues.apache.org/jira/browse/CB-7093
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin File
> Affects Versions: 3.5.0
> Reporter: Martin Gonzalez
> Assignee: Martin Gonzalez
> Labels: plugin-file
> Fix For: 3.6.0
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)