You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/28 16:24:13 UTC
[GitHub] [kafka-site] mumrah opened a new pull request, #446: MINOR: quick fix for TOC handle
mumrah opened a new pull request, #446:
URL: https://github.com/apache/kafka-site/pull/446
Seen in the prerelease of the 3.3 docs, the TOC handle overlaps with the main contents of the `.right` div.
The left margin for this div was "auto", which was not getting calculated correctly. This patch sets the left margin to 33 rem which is what the actual left margin is supposed to be. Since the TOC and handle are fixed width, it's okay to use a fixed margin as well.
**Current 3.3 docs:**
----------------
<img width="955" alt="image" src="https://user-images.githubusercontent.com/55116/192832666-3534e0aa-b242-4ffa-97e1-e49a16b61164.png">
----------------
**With this patch:**
----------------
<img width="952" alt="image" src="https://user-images.githubusercontent.com/55116/192832744-006838ea-04f6-480c-a7b7-c8964b9f7473.png">
----------------
There is likely some other issue in the body elements causing this margin to get miscalculated, though I couldn't find the root cause.
Tested in Chrome 106.0.5249.61 and Safari 15.6.1 on Mac OS 12.5.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #446: MINOR: quick fix for TOC handle
Posted by GitBox <gi...@apache.org>.
bbejeck commented on PR #446:
URL: https://github.com/apache/kafka-site/pull/446#issuecomment-1261514052
@mumrah the latest commit fixes it - thanks for the update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] mumrah commented on pull request #446: MINOR: quick fix for TOC handle
Posted by GitBox <gi...@apache.org>.
mumrah commented on PR #446:
URL: https://github.com/apache/kafka-site/pull/446#issuecomment-1261503708
Somehow I completely missed that bar thing. I think that's the culprit here, let me see if I can track down where its coming from
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #446: MINOR: quick fix for TOC handle
Posted by GitBox <gi...@apache.org>.
bbejeck commented on PR #446:
URL: https://github.com/apache/kafka-site/pull/446#issuecomment-1261467208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] mumrah merged pull request #446: MINOR: quick fix for TOC handle
Posted by GitBox <gi...@apache.org>.
mumrah merged PR #446:
URL: https://github.com/apache/kafka-site/pull/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org