You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/21 07:32:28 UTC

[GitHub] [airflow] darshan-majithiya commented on a change in pull request #15429: Add support for Hyperparameter Tuning on Google Cloud AI Platform

darshan-majithiya commented on a change in pull request #15429:
URL: https://github.com/apache/airflow/pull/15429#discussion_r617271272



##########
File path: airflow/providers/google/cloud/operators/mlengine.py
##########
@@ -1135,6 +1135,11 @@ class MLEngineStartTrainingJobOperator(BaseOperator):
         will be printed out. In 'CLOUD' mode, a real MLEngine training job
         creation request will be issued.
     :type mode: str
+    :param hyperparameters: Optional HyperparameterSpec dictionary for hyperparameter tuning
+        For further reference, check these:
+        https://cloud.google.com/ai-platform/training/docs/using-hyperparameter-tuning
+        https://cloud.google.com/ai-platform/training/docs/reference/rest/v1/projects.jobs#HyperparameterSpec
+    :type hyperparameters: Dict

Review comment:
       I'm not able to run this locally. It exists without any error message. 
   
   I tried pushing the code to PR but the build throws an error for the 2nd URL line - https://cloud.google.com/ai-platform/training/docs/reference/rest/v1/projects.jobs#HyperparameterSpec. The line has 112 characters and the max allowed is 110. Will it be okay if I modify the /airflow/pylintrc file and update the max-line-length value to 112? Or is there any other workaround?
       




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org