You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/09/20 03:29:21 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #3522][FOLLOWUP] Fix benchmark results-dir

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 73612b775 [KYUUBI #3522][FOLLOWUP] Fix benchmark results-dir
73612b775 is described below

commit 73612b7750264b6d43e48ee0277a89bd9de0b82a
Author: zwangsheng <22...@qq.com>
AuthorDate: Tue Sep 20 11:29:10 2022 +0800

    [KYUUBI #3522][FOLLOWUP] Fix benchmark results-dir
    
    ### _Why are the changes needed?_
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #3523 from zwangsheng/bugfix/bechmark_fix_result_dir.
    
    Closes #3522
    
    4f957960 [zwangsheng] rebase
    17de184f [zwangsheng] fix
    39361cfc [zwangsheng] fix
    
    Authored-by: zwangsheng <22...@qq.com>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala b/dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala
index 93f14e57e..71b980165 100644
--- a/dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala
+++ b/dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala
@@ -63,7 +63,7 @@ object RunBenchmark {
         .action((x, c) => c.copy(iterations = x))
         .text("the number of iterations to run")
       opt[String]('r', "results-dir")
-        .action((x, c) => c.copy(resultsDir = Some(x)))
+        .action((x, c) => c.copy(resultsDir = x))
         .text("dir to store benchmark results, e.g. hdfs://hdfs-nn:9870/pref")
       help("help")
         .text("prints this usage text")