You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/01 18:46:11 UTC

[GitHub] [superset] Steejay edited a comment on issue #12436: [sql_lab]Display Rows Returned / Clarify when LIMIT is reached

Steejay edited a comment on issue #12436:
URL: https://github.com/apache/superset/issues/12436#issuecomment-771073296


   wanted to share this mockup here that shows a row returned indicator with additional info upon hover. I positioned the indicator under the results tab since it has a direct relationship with the result table. 
   
   The indicator displays w a success check icon when the row returned matches the limit dropdown or the limit specified in the query w a tooltip that adds context.
   
   The indicator displays with a warning icon when the row returned _does not_ match the limit dropdown w a tooltip that describes why.  ie "The number of rows displayed is limited by the flag DISPLAY_MAX_ROWS = 1000".
   
   ![Frame 254](https://user-images.githubusercontent.com/60786102/106502182-e5409480-6478-11eb-9e07-4814ea5a9282.jpg)
   
   ![Frame 255 (1)](https://user-images.githubusercontent.com/60786102/106503021-ffc73d80-6479-11eb-8750-1dafbe2684a0.jpg)
   
   cc @yousoph @tooptoop4 @himanshpal @ramyarajasekaran @mihir174 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org