You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "ebarboni (via GitHub)" <gi...@apache.org> on 2024/12/10 16:12:27 UTC
[PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
ebarboni opened a new pull request, #8034:
URL: https://github.com/apache/netbeans/pull/8034
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878450220
##########
java/java.completion/nbproject/org-netbeans-modules-java-completion.sig:
##########
@@ -1,5 +1,9 @@
#Signature file v4.1
+<<<<<<< Updated upstream
#Version 2.13.0
+=======
+#Version 2.12.0
+>>>>>>> Stashed changes
Review Comment:
fixed for what is in master
##########
webcommon/lib.chrome_devtools_protocol/nbproject/org-netbeans-lib-chrome_devtools_protocol.sig:
##########
@@ -1,5 +1,9 @@
#Signature file v4.1
+<<<<<<< Updated upstream
#Version 2.0
+=======
+#Version 1.2
+>>>>>>> Stashed changes
Review Comment:
fixed for what is in master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878511961
##########
enterprise/libs.fabric8/nbproject/org-netbeans-libs-fabric8.sig:
##########
Review Comment:
https://github.com/apache/netbeans/pull/7826 added 29 jars for a deploy aciton
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni merged PR #8034:
URL: https://github.com/apache/netbeans/pull/8034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878421430
##########
java/java.completion/nbproject/org-netbeans-modules-java-completion.sig:
##########
@@ -1,5 +1,9 @@
#Signature file v4.1
+<<<<<<< Updated upstream
#Version 2.13.0
+=======
+#Version 2.12.0
+>>>>>>> Stashed changes
Review Comment:
this is wrong
##########
java/java.completion/nbproject/org-netbeans-modules-java-completion.sig:
##########
Review Comment:
this is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#issuecomment-2536299413
do you think we can merge, and let discussion on PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#issuecomment-2536680999
The idea of @neilcsmith-net sounds like a good approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878422200
##########
webcommon/lib.chrome_devtools_protocol/nbproject/org-netbeans-lib-chrome_devtools_protocol.sig:
##########
@@ -1,5 +1,9 @@
#Signature file v4.1
+<<<<<<< Updated upstream
#Version 2.0
+=======
+#Version 1.2
+>>>>>>> Stashed changes
Review Comment:
this is wrong
##########
webcommon/lib.chrome_devtools_protocol/nbproject/org-netbeans-lib-chrome_devtools_protocol.sig:
##########
Review Comment:
this is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#issuecomment-2536706475
agreed. I thought about disabling the sig checks for the wrapper, but this could cause conflicts dependent on what is going to happen next. So removal of `org-netbeans-libs-fabric8.sig` from this PR without further changes sounds like the best approach to get this PR integrated without delays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878556127
##########
enterprise/libs.fabric8/nbproject/org-netbeans-libs-fabric8.sig:
##########
Review Comment:
Looks like they were wrongly attributed too - https://github.com/apache/netbeans/blob/master/enterprise/libs.fabric8/external/fabric8-2.17.2-license.txt#L4
I hope the license is correct!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878407199
##########
java/java.completion/nbproject/org-netbeans-modules-java-completion.sig:
##########
Review Comment:
this is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#issuecomment-2536659983
I would suggest removing that one file (`org-netbeans-libs-fabric8.sig`), amending and force pushing the commit, and getting this merged before anything else starts conflicting with it. It can always be added back later depending on where that conversation ends up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878629169
##########
webcommon/lib.chrome_devtools_protocol/nbproject/org-netbeans-lib-chrome_devtools_protocol.sig:
##########
@@ -1,5 +1,9 @@
#Signature file v4.1
+<<<<<<< Updated upstream
#Version 2.0
+=======
+#Version 1.2
+>>>>>>> Stashed changes
Review Comment:
Thank you and yes the version in master is correct. I merged the JS ChromeDevTool fixes into master and overlooked, that this would clash here. Sorry about that!
If I see this correctly, the file is not in the commit anymore, which looks right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878406500
##########
webcommon/lib.chrome_devtools_protocol/nbproject/org-netbeans-lib-chrome_devtools_protocol.sig:
##########
Review Comment:
this is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#discussion_r1878491971
##########
enterprise/libs.fabric8/nbproject/org-netbeans-libs-fabric8.sig:
##########
Review Comment:
this file is 14 MB large (!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#issuecomment-2532255593
comment fixed to what version is in master (thanks @neilcsmith-net for assistance :D )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#issuecomment-2536413976
IMO: I don't think it makes sense to maintain 14MB sig files over third party libs in our source code repo. The usefulness of sigs over dependencies is more of informational nature anyway since their API is not something we can influence. I don't have anything against them in principle - but a 14mb text file is a bit much in this particular case.
Whether the 29 new dependencies for a Kubernetes deploy action are justified or not I don't know, since I don't see any cost/benefit analysis or discussion anywhere which compares other options. But there are essentially three likely outcomes: a) PR gets reverted and we regen the sigs or b) cost/benefit is justified and we turn sig tests off for that set of dependencies. c) we merge it as is
I don't think we should merge this as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#issuecomment-2539018285
diff stats with all one-line changes removed to make it easier to inspect:
```
.../nbproject/org-netbeans-libs-jackson.sig | 398 +++++++++++++++++-
.../org-netbeans-modules-payara-common.sig | 10 +-
.../org-netbeans-modules-payara-micro.sig | 9 +-
.../org-netbeans-modules-payara-tooling.sig | 18 +-
.../org-netbeans-modules-websvc-restlib.sig | 8 +-
.../nbproject/org-netbeans-modules-gradle.sig | 26 +-
.../nbproject/org-netbeans-api-lsp.sig | 7 +-
.../org-netbeans-modules-css-lib.sig | 3 +-
.../nbproject/org-netbeans-libs-git.sig | 8 +-
.../org-netbeans-modules-lsp-client.sig | 5 +-
.../org-netbeans-modules-parsing-indexing.sig | 3 +-
...rg-netbeans-modules-java-file-launcher.sig | 4 +-
.../org-netbeans-modules-java-lexer.sig | 10 +-
.../org-netbeans-modules-java-source-base.sig | 54 ++-
.../org-netbeans-modules-java-source.sig | 7 +-
.../org-netbeans-modules-java-sourceui.sig | 13 +-
.../org-netbeans-modules-maven-embedder.sig | 295 +------------
.../org-netbeans-modules-maven-indexer.sig | 41 +-
.../nbproject/org-netbeans-modules-maven.sig | 5 +-
.../org-netbeans-modules-refactoring-java.sig | 13 +-
.../nbproject/org-netbeans-libs-asm.sig | 11 +-
.../nbproject/org-netbeans-libs-flatlaf.sig | 5 +-
.../org-netbeans-libs-javax-inject.sig | 63 +++
.../nbproject/org-netbeans-bootstrap.sig | 4 +-
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Snapshot of APIS as of NetBeans 24 take2 [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #8034:
URL: https://github.com/apache/netbeans/pull/8034#issuecomment-2538996872
sorry for delay sig file should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists