[GitHub] [incubator-dolphinscheduler] samz406 commented on a change in pull request #1607: project checkResult may NPE

[GitBox <gi...@apache.org>]

samz406 commented on a change in pull request #1607: project checkResult may NPE
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1607#discussion_r361607503
 
 

 ##########
 File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProjectService.java
 ##########
 @@ -143,7 +143,7 @@
     public boolean hasProjectAndPerm(User loginUser, Project project, Map<String, Object> result) {
         boolean checkResult = false;
         if (project == null) {
-            putMsg(result, Status.PROJECT_NOT_FOUNT, project.getName());
+            putMsg(result, Status.PROJECT_NOT_FOUNT, "");
 
 Review comment:
   This method is called in many places. It may be query by projectId or the query by projectName, so it is difficult to pass the right project name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services