You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/07/20 19:37:51 UTC

[jira] Created: (PIG-1507) Full outer join fails while doing a filter on joined data

Full outer join fails while doing a filter on joined data
---------------------------------------------------------

                 Key: PIG-1507
                 URL: https://issues.apache.org/jira/browse/PIG-1507
             Project: Pig
          Issue Type: Bug
          Components: impl
    Affects Versions: 0.8.0
            Reporter: Daniel Dai
            Assignee: Daniel Dai
             Fix For: 0.8.0


The following script produce wrong result:

test1.dat:
1
2
3

test2.dat:
1
2

pig script:
{code}
a = LOAD 'test1.dat' USING PigStorage() AS (d1:int);
b = LOAD 'test2.dat' USING PigStorage() AS (d2:int);
c = JOIN a BY d1 FULL OUTER, b BY d2;
d = FILTER c BY d2 IS NULL;
STORE d INTO 'test.out' USING PigStorage();
{code}

expected:
3

We get:
1
2
3

This is because we erroneously push the filter before full outer join. Similar issue is addressed in [PIG-1289|https://issues.apache.org/jira/browse/PIG-1289], but we only fix left/right outer join.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1507) Full outer join fails while doing a filter on joined data

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1507:
----------------------------

           Status: Resolved  (was: Patch Available)
     Hadoop Flags: [Reviewed]
    Fix Version/s: 0.7.0
       Resolution: Fixed

Patch committed to both trunk and 0.7 branch.

> Full outer join fails while doing a filter on joined data
> ---------------------------------------------------------
>
>                 Key: PIG-1507
>                 URL: https://issues.apache.org/jira/browse/PIG-1507
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0, 0.7.0
>
>         Attachments: PIG-1507-1.patch
>
>
> The following script produce wrong result:
> test1.dat:
> 1
> 2
> 3
> test2.dat:
> 1
> 2
> pig script:
> {code}
> a = LOAD 'test1.dat' USING PigStorage() AS (d1:int);
> b = LOAD 'test2.dat' USING PigStorage() AS (d2:int);
> c = JOIN a BY d1 FULL OUTER, b BY d2;
> d = FILTER c BY d2 IS NULL;
> STORE d INTO 'test.out' USING PigStorage();
> {code}
> expected:
> 3
> We get:
> 1
> 2
> 3
> This is because we erroneously push the filter before full outer join. Similar issue is addressed in [PIG-1289|https://issues.apache.org/jira/browse/PIG-1289], but we only fix left/right outer join.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1507) Full outer join fails while doing a filter on joined data

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890521#action_12890521 ] 

Hadoop QA commented on PIG-1507:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12449962/PIG-1507-1.patch
  against trunk revision 965559.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/348/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/348/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/348/console

This message is automatically generated.

> Full outer join fails while doing a filter on joined data
> ---------------------------------------------------------
>
>                 Key: PIG-1507
>                 URL: https://issues.apache.org/jira/browse/PIG-1507
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1507-1.patch
>
>
> The following script produce wrong result:
> test1.dat:
> 1
> 2
> 3
> test2.dat:
> 1
> 2
> pig script:
> {code}
> a = LOAD 'test1.dat' USING PigStorage() AS (d1:int);
> b = LOAD 'test2.dat' USING PigStorage() AS (d2:int);
> c = JOIN a BY d1 FULL OUTER, b BY d2;
> d = FILTER c BY d2 IS NULL;
> STORE d INTO 'test.out' USING PigStorage();
> {code}
> expected:
> 3
> We get:
> 1
> 2
> 3
> This is because we erroneously push the filter before full outer join. Similar issue is addressed in [PIG-1289|https://issues.apache.org/jira/browse/PIG-1289], but we only fix left/right outer join.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1507) Full outer join fails while doing a filter on joined data

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1507:
----------------------------

    Status: Patch Available  (was: Open)

> Full outer join fails while doing a filter on joined data
> ---------------------------------------------------------
>
>                 Key: PIG-1507
>                 URL: https://issues.apache.org/jira/browse/PIG-1507
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1507-1.patch
>
>
> The following script produce wrong result:
> test1.dat:
> 1
> 2
> 3
> test2.dat:
> 1
> 2
> pig script:
> {code}
> a = LOAD 'test1.dat' USING PigStorage() AS (d1:int);
> b = LOAD 'test2.dat' USING PigStorage() AS (d2:int);
> c = JOIN a BY d1 FULL OUTER, b BY d2;
> d = FILTER c BY d2 IS NULL;
> STORE d INTO 'test.out' USING PigStorage();
> {code}
> expected:
> 3
> We get:
> 1
> 2
> 3
> This is because we erroneously push the filter before full outer join. Similar issue is addressed in [PIG-1289|https://issues.apache.org/jira/browse/PIG-1289], but we only fix left/right outer join.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1507) Full outer join fails while doing a filter on joined data

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1507:
----------------------------

    Attachment: PIG-1507-1.patch

> Full outer join fails while doing a filter on joined data
> ---------------------------------------------------------
>
>                 Key: PIG-1507
>                 URL: https://issues.apache.org/jira/browse/PIG-1507
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1507-1.patch
>
>
> The following script produce wrong result:
> test1.dat:
> 1
> 2
> 3
> test2.dat:
> 1
> 2
> pig script:
> {code}
> a = LOAD 'test1.dat' USING PigStorage() AS (d1:int);
> b = LOAD 'test2.dat' USING PigStorage() AS (d2:int);
> c = JOIN a BY d1 FULL OUTER, b BY d2;
> d = FILTER c BY d2 IS NULL;
> STORE d INTO 'test.out' USING PigStorage();
> {code}
> expected:
> 3
> We get:
> 1
> 2
> 3
> This is because we erroneously push the filter before full outer join. Similar issue is addressed in [PIG-1289|https://issues.apache.org/jira/browse/PIG-1289], but we only fix left/right outer join.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1507) Full outer join fails while doing a filter on joined data

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890892#action_12890892 ] 

Richard Ding commented on PIG-1507:
-----------------------------------

+1

> Full outer join fails while doing a filter on joined data
> ---------------------------------------------------------
>
>                 Key: PIG-1507
>                 URL: https://issues.apache.org/jira/browse/PIG-1507
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1507-1.patch
>
>
> The following script produce wrong result:
> test1.dat:
> 1
> 2
> 3
> test2.dat:
> 1
> 2
> pig script:
> {code}
> a = LOAD 'test1.dat' USING PigStorage() AS (d1:int);
> b = LOAD 'test2.dat' USING PigStorage() AS (d2:int);
> c = JOIN a BY d1 FULL OUTER, b BY d2;
> d = FILTER c BY d2 IS NULL;
> STORE d INTO 'test.out' USING PigStorage();
> {code}
> expected:
> 3
> We get:
> 1
> 2
> 3
> This is because we erroneously push the filter before full outer join. Similar issue is addressed in [PIG-1289|https://issues.apache.org/jira/browse/PIG-1289], but we only fix left/right outer join.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.