You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/05/26 21:09:32 UTC
[GitHub] [trafficcontrol] traeak opened a new pull request, #6865: t3c/regex_revalidate: remove STALE keyword for default rule.
traeak opened a new pull request, #6865:
URL: https://github.com/apache/trafficcontrol/pull/6865
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
-->
Closes: #6858
<--
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Fix to t3c's regex_revalidate handling to NOT add STALE to the end of a default regex_revalidate rule. This allow for greater ATS version compatibility.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Control Cache Config (`t3c`, formerly ORT)
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Create a default regex_revalidate rule with STALE. Generated t3c file should not contain STALE anywhere in the file. REFRESH rules will still have MISS in the same file.
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation -- minor behavior change.
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] traeak commented on a diff in pull request #6865: t3c/regex_revalidate: remove STALE keyword for default rule.
Posted by GitBox <gi...@apache.org>.
traeak commented on code in PR #6865:
URL: https://github.com/apache/trafficcontrol/pull/6865#discussion_r883096309
##########
lib/go-atscfg/regexrevalidatedotconfig.go:
##########
@@ -41,6 +41,12 @@ const DefaultMaxRevalDurationDays = 90
const JobKeywordPurge = "PURGE"
const RegexRevalidateMinTTL = time.Hour
+type RevalType string
+
+const MISS = RevalType("MISS")
Review Comment:
Okay i can do that. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c merged pull request #6865: t3c/regex_revalidate: remove STALE keyword for default rule.
Posted by GitBox <gi...@apache.org>.
rob05c merged PR #6865:
URL: https://github.com/apache/trafficcontrol/pull/6865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #6865: t3c/regex_revalidate: remove STALE keyword for default rule.
Posted by GitBox <gi...@apache.org>.
rob05c commented on code in PR #6865:
URL: https://github.com/apache/trafficcontrol/pull/6865#discussion_r883089000
##########
lib/go-atscfg/regexrevalidatedotconfig.go:
##########
@@ -41,6 +41,12 @@ const DefaultMaxRevalDurationDays = 90
const JobKeywordPurge = "PURGE"
const RegexRevalidateMinTTL = time.Hour
+type RevalType string
+
+const MISS = RevalType("MISS")
Review Comment:
Nitpick: Go variables, including consts, should be CamelCase. Should be `const Miss` and `const Stale`.
Personally, for enums I prefer `RevalTypeMiss` and `RevalTypeStale`, just for clarity. Especially since they're scoped to the entire `atscfg` package
https://go.dev/doc/effective_go#names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #6865: t3c/regex_revalidate: remove STALE keyword for default rule.
Posted by GitBox <gi...@apache.org>.
rob05c commented on code in PR #6865:
URL: https://github.com/apache/trafficcontrol/pull/6865#discussion_r883089000
##########
lib/go-atscfg/regexrevalidatedotconfig.go:
##########
@@ -41,6 +41,12 @@ const DefaultMaxRevalDurationDays = 90
const JobKeywordPurge = "PURGE"
const RegexRevalidateMinTTL = time.Hour
+type RevalType string
+
+const MISS = RevalType("MISS")
Review Comment:
Nitpick: Go variables, including consts, should be CamelCase. Should be `const Miss` and `const Stale`.
Personally, for enums I prefer `RevalTypeMiss` and `RevalTypeStale`, just for clarity. Especially since they're scoped to the entire `atscfg` package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org