You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/18 03:32:46 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
HyukjinKwon opened a new pull request #31226:
URL: https://github.com/apache/spark/pull/31226
### What changes were proposed in this pull request?
This PR is a followup of #27433. It fixes the naming to match with Scala side, and this is similar with https://github.com/apache/spark/pull/31062.
Note that:
- there are a bit of inconsistency already e.g.) `x`, `y` in SparkR and they are documented together for doc deduplication. This part I did not change but the name `zero` vs `initialValue` looks unnecessary.
- such naming matching seems already pretty common in SparkR.
### Why are the changes needed?
To make the usage similar with Scala side, and for consistency.
### Does this PR introduce _any_ user-facing change?
No, this is not released yet.
### How was this patch tested?
GitHub Actions and Jenkins build will test it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761957206
@dongjoon-hyun and @viirya, would you mind taking a quick look please?
@zero323 and @mengxr FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31226:
URL: https://github.com/apache/spark/pull/31226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761964862
**[Test build #134176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134176/testReport)** for PR 31226 at commit [`535bc85`](https://github.com/apache/spark/commit/535bc855a0995b6f6112c14a8d55010c3b5b6a45).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761986661
Merged to master and branch-3.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761959200
lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761976903
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38760/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761964862
**[Test build #134176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134176/testReport)** for PR 31226 at commit [`535bc85`](https://github.com/apache/spark/commit/535bc855a0995b6f6112c14a8d55010c3b5b6a45).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761975075
**[Test build #134176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134176/testReport)** for PR 31226 at commit [`535bc85`](https://github.com/apache/spark/commit/535bc855a0995b6f6112c14a8d55010c3b5b6a45).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761975450
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38760/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761978690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-762020693
+1, late LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31226: [SPARK-30682][R][SQL][FOLLOW-UP] Keep the name similar with Scala side in higher order functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31226:
URL: https://github.com/apache/spark/pull/31226#issuecomment-761978690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org