You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/03/25 18:06:44 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3940: Avoid memory copies in take_list

viirya commented on code in PR #3940:
URL: https://github.com/apache/arrow-rs/pull/3940#discussion_r1148410724


##########
arrow-select/src/take.rs:
##########
@@ -912,7 +912,7 @@ where
 
             // if start == end, this slot is empty
             while curr < end {
-                values.push(Some(curr));

Review Comment:
   This looks redundant previously.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org