You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Dave <sn...@gmail.com> on 2013/04/06 15:33:48 UTC
Re: Uh Oh... (Re: svn commit: r1465236 - /roller/trunk/weblogger-business/src/main/java/org/apache/roller/weblogger/util/MailUtil.java)
On Sat, Apr 6, 2013 at 9:11 AM, Glen Mazza <gl...@gmail.com> wrote:
> Dave, please update your IDE (and fix this commit) to replace tabs with
> four spaces...the spacing below in your latest change indicates actual tab
> characters are being used.
>
Yuck, tabs! Unfortunately, we use tabs where I work. Just committed a fix
for this.
- Dave
Re: Uh Oh... (Re: svn commit: r1465236 - /roller/trunk/weblogger-business/src/main/java/org/apache/roller/weblogger/util/MailUtil.java)
Posted by Dave <sn...@gmail.com>.
Yeah, my commit did not fix the problem. I just committed a new fix that
replaces all tabs with spaces and I switched my Roller Netbeans projects
over to use "project specific settings" and 4-spaces instead of tabs.
- Dave
On Sat, Apr 6, 2013 at 9:37 AM, Glen Mazza <gl...@gmail.com> wrote:
> At least in Eclipse, if you create a separate workspace for
> space-delimited Apache projects, you can dictate spaces for tabs in that
> particular workspace. (I can provide more config info if needed.)
>
> I'm not sure your commit fixed that problem -- it just shows one line
> being changed, but according to the svn commit mail the entire "if
> (notifySubscribers) {" block is tab-delimited.
>
> Glen
>
>
> On 04/06/2013 09:33 AM, Dave wrote:
>
>> On Sat, Apr 6, 2013 at 9:11 AM, Glen Mazza <gl...@gmail.com> wrote:
>>
>> Dave, please update your IDE (and fix this commit) to replace tabs with
>>> four spaces...the spacing below in your latest change indicates actual
>>> tab
>>> characters are being used.
>>>
>>> Yuck, tabs! Unfortunately, we use tabs where I work. Just committed a
>> fix
>> for this.
>>
>> - Dave
>>
>>
>
Re: Uh Oh... (Re: svn commit: r1465236 - /roller/trunk/weblogger-business/src/main/java/org/apache/roller/weblogger/util/MailUtil.java)
Posted by Glen Mazza <gl...@gmail.com>.
At least in Eclipse, if you create a separate workspace for
space-delimited Apache projects, you can dictate spaces for tabs in that
particular workspace. (I can provide more config info if needed.)
I'm not sure your commit fixed that problem -- it just shows one line
being changed, but according to the svn commit mail the entire "if
(notifySubscribers) {" block is tab-delimited.
Glen
On 04/06/2013 09:33 AM, Dave wrote:
> On Sat, Apr 6, 2013 at 9:11 AM, Glen Mazza <gl...@gmail.com> wrote:
>
>> Dave, please update your IDE (and fix this commit) to replace tabs with
>> four spaces...the spacing below in your latest change indicates actual tab
>> characters are being used.
>>
> Yuck, tabs! Unfortunately, we use tabs where I work. Just committed a fix
> for this.
>
> - Dave
>