Re: BEWARE OF cvs commit: jakarta-jmeter/xdocs/usermanual build-ftp-test-plan.xml build-web-test-plan.xml component_reference.x

[Mike Stover <ms...@apache.org>]

Thanks for the heads-up.

-Mike

On 20 Jun 2002 at 10:45, Jordi Salvat i Alabart wrote:

> Hi Mike.
> 
> The CVS update you just did contains:
> 
> 
> >   Index: HttpRequestHdr.java
> >   ===================================================================
> >   RCS file: /home/cvs/jakarta-jmeter/src_1/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java,v
> >   retrieving revision 1.11
> >   retrieving revision 1.12
> >   diff -u -r1.11 -r1.12
> >   --- HttpRequestHdr.java	18 Jun 2002 01:32:17 -0000	1.11
> >   +++ HttpRequestHdr.java	19 Jun 2002 19:56:20 -0000	1.12
> >   @@ -160,6 +160,8 @@
> >    	{
> >    		HttpTestSampleGui tempGui = new HttpTestSampleGui();
> >    		tempGui.configure(createUrlConfig());
> >   +		HTTPSampler result = (HTTPSampler)tempGui.createTestElement();
> >   +		result.setFollowRedirects(false);
> >    		return (HTTPSampler)tempGui.createTestElement();
> >    	}
> >    
> >   @@ -174,7 +176,6 @@
> >    		urlConfig.setDomain(serverName());
> >    		urlConfig.setMethod(method);
> >    		urlConfig.setPath(serverUrl());
> >   -		urlConfig.setProperty(HTTPSampler.FOLLOW_REDIRECTS,new Boolean(true));
> >    		urlConfig.setName(urlConfig.getPath());
> >    		if(url.indexOf(":") > -1)
> >    		{
> >   
> 
> The "return (HTTPSampler)..." line should be simply
> 
> 		return result;
> 
> Otherwise you'll not on only not get the intended functionality, but 
> also get a bug because of the non-definition of the FOLLOW_REDIRECTS 
> property.
> 
> Salut,
> 
> Jordi.
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 



--
Michael Stover
mstover1@apache.org
Yahoo IM: mstover_ya
ICQ: 152975688

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>