[GitHub] reddycharan commented on a change in pull request #1576: Record ctime for underreplicated ledger mark time.

[GitBox <gi...@apache.org>]

reddycharan commented on a change in pull request #1576: Record ctime for underreplicated ledger mark time.
URL: https://github.com/apache/bookkeeper/pull/1576#discussion_r207993270
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
 ##########
 @@ -931,14 +932,17 @@ int runCmd(CommandLine cmdLine) throws Exception {
                     Thread.currentThread().interrupt();
                     throw new UncheckedExecutionException("Interrupted on newing ledger underreplicated manager", e);
                 }
-                Iterator<Map.Entry<Long, List<String>>> iter = underreplicationManager
-                        .listLedgersToRereplicate(predicate, printMissingReplica);
+                Iterator<UnderreplicatedLedger> iter = underreplicationManager.listLedgersToRereplicate(predicate);
                 while (iter.hasNext()) {
-                    Map.Entry<Long, List<String>> urLedgerMapEntry = iter.next();
-                    long urLedgerId = urLedgerMapEntry.getKey();
+                    UnderreplicatedLedger underreplicatedLedger = iter.next();
+                    long urLedgerId = underreplicatedLedger.getLedgerId();
                     System.out.println(ledgerIdFormatter.formatLedgerId(urLedgerId));
+                    long ctime = underreplicatedLedger.getCtime();
+                    if (ctime != -1) {
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services