[GitHub] [superset] michael-s-molina commented on a change in pull request #14174: chore: Rewrites dashboard IconButton component

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #14174:
URL: https://github.com/apache/superset/pull/14174#discussion_r627494791



##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
##########
@@ -61,12 +61,19 @@ const HEADER_HEIGHT = 67;
 
 type DashboardBuilderProps = {};
 
-const StyledDashboardContent = styled.div<{ dashboardFiltersOpen: boolean }>`
+const StyledDashboardContent = styled.div<{
+  dashboardFiltersOpen: boolean;
+  editMode: boolean;
+}>`
   display: flex;
   flex-direction: row;
   flex-wrap: nowrap;
   height: auto;
   flex-grow: 1;
+  padding-left: ${({ theme, editMode }) => {

Review comment:
       I did but then it raises https://eslint.org/docs/rules/no-confusing-arrow. That's why it's using curly braces.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org