[GitHub] [superset] codemaster08240328 commented on a diff in pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select

[GitBox <gi...@apache.org>]

codemaster08240328 commented on code in PR #19651:
URL: https://github.com/apache/superset/pull/19651#discussion_r848361725


##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx:
##########
@@ -127,14 +127,7 @@ export function DndColumnSelect(props: DndColumnSelectProps) {
   );
 
   const popoverOptions = useMemo(
-    () =>
-      Object.values(options).filter(
-        col =>
-          !optionSelector.values
-            .filter(isColumnMeta)
-            .map((val: ColumnMeta) => val.column_name)
-            .includes(col.column_name),

Review Comment:
   Did you confirm that we don't have other side effects by removing this filter?
   
   If we really don't need this filter, can you add the reason into PR description so others can get an idea?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org