[jira] [Commented] (YARN-2914) Potential race condition in ClientSCMMetrics#getInstance()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231685#comment-14231685 ] 

Hadoop QA commented on YARN-2914:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12684673/YARN-2914.patch
  against trunk revision 75d5345.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5977//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5977//console

This message is automatically generated.

> Potential race condition in ClientSCMMetrics#getInstance()
> ----------------------------------------------------------
>
>                 Key: YARN-2914
>                 URL: https://issues.apache.org/jira/browse/YARN-2914
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Ted Yu
>            Assignee: Varun Saxena
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: YARN-2914.patch
>
>
> {code}
>   public static ClientSCMMetrics getInstance() {
>     ClientSCMMetrics topMetrics = Singleton.INSTANCE.impl;
>     if (topMetrics == null) {
>       throw new IllegalStateException(
> {code}
> getInstance() doesn't hold lock on Singleton.this
> This may result in IllegalStateException being thrown prematurely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)