[GitHub] [druid] suneet-s commented on a change in pull request #9373: Fix join filter push down post-join virtual column handling

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #9373: Fix join filter push down post-join virtual column handling
URL: https://github.com/apache/druid/pull/9373#discussion_r381437918
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
 ##########
 @@ -297,6 +302,22 @@ public boolean isEnableFilterPushDown()
     return enableFilterPushDown;
   }
 
+  @VisibleForTesting
+  public Set<String> getAdapterBaseColumnNamesWithVirtualColumns(VirtualColumns virtualColumns)
+  {
+    final Set<String> baseColumns = new HashSet<>();
+    Iterables.addAll(baseColumns, baseAdapter.getAvailableDimensions());
+    Iterables.addAll(baseColumns, baseAdapter.getAvailableMetrics());
+
+    for (VirtualColumn virtualColumn : virtualColumns.getVirtualColumns()) {
+      if (baseColumns.containsAll(virtualColumn.requiredColumns())) {
 
 Review comment:
   This is very similar to the code above in makeCursors(...) Perhaps move this into a utility function so they stay in sync. Or do you want this function to provide different functionality?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org