You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/09 15:12:43 UTC

[GitHub] [airflow] bochkarevnv opened a new issue #14683: PostgreSQL connection does not use option target_session_attrs

bochkarevnv opened a new issue #14683:
URL: https://github.com/apache/airflow/issues/14683

<!--

Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)

If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>

Please delete these comment blocks before submitting the issue.

-->

<!--

IMPORTANT!!!

PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!

PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!

Please complete the next sections or the issue will be closed.
These questions are the first thing we need to know to understand the context.

-->

**Apache Airflow version**: 1.10.14

**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): -

**Environment**:

- **Cloud provider or hardware configuration**: Intel i5-8250U 16GB RAM
- **OS** (e.g. from /etc/os-release): Debian GNU/Linux 9 (stretch)
- **Kernel** (e.g. `uname -a`): Linux 635b29b988b2 4.19.128-microsoft-standard #1 SMP Tue Jun 23 12:58:10 UTC 2020 x86_64 GNU/Linux
- **Install tools**: Run Airflow in Docker containers
- **Others**: I have two Postgresql servers in cluster: master and read-only replica

**What happened**:
I create new connection:
```
Conn Id: two_postgresql
Conn Type:Postgres
Host: replica,master
Schema: test
Login: test
Port: 5432
Extra: {"target_session_attrs": "read-write"}
```

Then go to Ad Hoc Query choose two_postgresql connection and run query: `SHOW transaction_read_only;`
And I see that transaction_read_only is **on**. It means that airflow connect to replica, because target_session_attrs parameter ignored.

**What you expected to happen**:

I expect that transaction_read_only is **off** and airflow connect to master.

**How to reproduce it**:
<!---

As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.

If you are using kubernetes, please attempt to recreate the issue using minikube or kind.

## Install minikube/kind

- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/

If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action

You can include images using the .md style of
![alt text](http://url/to/img.png)

To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.

--->

**Anything else we need to know**:
Parameter target_session_attrs correctly works with psycopg2.
I think this problem caused by this filter of extra parameters: https://github.com/apache/airflow/blob/1.10.14/airflow/hooks/postgres_hook.py#L88
<!--

How often does this problem occur? Once? Every time etc?

Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>

-->

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org