You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/17 20:18:09 UTC
[GitHub] [pulsar] addisonj opened a new pull request #13385: Fix a bug with MutliRoleTokenAuth and chained auth
addisonj opened a new pull request #13385:
URL: https://github.com/apache/pulsar/pull/13385
### Motivation
If a user has configured chained authentication with
MultiRolesTokenAuthorizationProvider, it is possible that a token
could be passed that is not a JWT.
### Modifications
In this case, we just want to return an empty list of roles and let the
default role pass through
### Verifying this change
- [ X] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- Adds a simple test for the failing case of a token that is not a JWT to ensure it doesn't fail
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
NO to all
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ X] `no-need-doc`
Minor bug fix
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on pull request #13385: Fix a bug with MutliRoleTokenAuth and chained auth
Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #13385:
URL: https://github.com/apache/pulsar/pull/13385#issuecomment-1007694587
Closing this as #13477 fixes it instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj commented on pull request #13385: Fix a bug with MutliRoleTokenAuth and chained auth
Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #13385:
URL: https://github.com/apache/pulsar/pull/13385#issuecomment-1007694587
Closing this as #13477 fixes it instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj closed pull request #13385: Fix a bug with MutliRoleTokenAuth and chained auth
Posted by GitBox <gi...@apache.org>.
addisonj closed pull request #13385:
URL: https://github.com/apache/pulsar/pull/13385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #13385: Fix a bug with MutliRoleTokenAuth and chained auth
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #13385:
URL: https://github.com/apache/pulsar/pull/13385#issuecomment-1000610432
I have created a PR to fix the fail unit test here: https://github.com/apache/pulsar/pull/13477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13385: Fix a bug with MutliRoleTokenAuth and chained auth
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13385:
URL: https://github.com/apache/pulsar/pull/13385#issuecomment-1036617503
Removing release label and milestone since the PR is closed. Please re-add if we need to open the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] addisonj closed pull request #13385: Fix a bug with MutliRoleTokenAuth and chained auth
Posted by GitBox <gi...@apache.org>.
addisonj closed pull request #13385:
URL: https://github.com/apache/pulsar/pull/13385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org