You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "berkaysynnada (via GitHub)" <gi...@apache.org> on 2023/08/31 15:13:53 UTC
[GitHub] [arrow-datafusion] berkaysynnada opened a new issue, #7458: Mismatch in query results in the local machine
berkaysynnada opened a new issue, #7458:
URL: https://github.com/apache/arrow-datafusion/issues/7458
When I run the sqllogictests on my computer, all query results including a NaN value give an error in scalar.slt file. Some examples:
```
External error: query result mismatch:
[SQL] select round(ln(a), 5), round(ln(b), 5), round(ln(c), 5) from signed_integers;
[Diff] (-expected|+actual)
- -NaN 4.60517 -NaN
- -NaN 9.21034 -NaN
- 0.69315 -NaN 4.81218
- 1.38629 NULL NULL
+ 0.69315 NaN 4.81218
+ 1.38629 NULL NULL
+ NaN 4.60517 NaN
+ NaN 9.21034 NaN
at test_files/scalar.slt:543
```
```
External error: query result mismatch:
[SQL] select log(a, 64) a, log(b), log(10, b) from signed_integers;
[Diff] (-expected|+actual)
- -NaN 2 2
- -NaN 4 4
3 NULL NULL
- 6 -NaN -NaN
+ 6 NaN NaN
+ NaN 2 2
+ NaN 4 4
at test_files/scalar.slt:595
```
Rows with NaN values are somehow listed towards the end of the table. So the tests don't pass in my local but in CI I don't get an error. Do you have any opinion about this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jonahgao commented on issue #7458: Mismatch in query results in the local machine
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao commented on issue #7458:
URL: https://github.com/apache/arrow-datafusion/issues/7458#issuecomment-1702815327
I encountered the same error on my ARM MacBook.
```
Running "scalar.slt"
External error: query result mismatch:
[SQL] select round(ln(a), 5), round(ln(b), 5), round(ln(c), 5) from signed_integers;
[Diff] (-expected|+actual)
- -NaN 4.60517 -NaN
- -NaN 9.21034 -NaN
- 0.69315 -NaN 4.81218
- 1.38629 NULL NULL
+ 0.69315 NaN 4.81218
+ 1.38629 NULL NULL
+ NaN 4.60517 NaN
+ NaN 9.21034 NaN
at test_files/scalar.slt:543
Error: Execution("1 failures")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] berkaysynnada commented on issue #7458: Mismatch in query results in the local machine
Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada commented on issue #7458:
URL: https://github.com/apache/arrow-datafusion/issues/7458#issuecomment-1702550086
Expected -NaN results in the query outputs become NaN in my local tests. What could be the reason for this? As far as I know, there is no -NaN in IEEE 754.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jayzhan211 commented on issue #7458: Mismatch in query results in the local machine
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on issue #7458:
URL: https://github.com/apache/arrow-datafusion/issues/7458#issuecomment-1702829057
> I encountered the same error on my ARM MacBook.
>
> ```
> Running "scalar.slt"
> External error: query result mismatch:
> [SQL] select round(ln(a), 5), round(ln(b), 5), round(ln(c), 5) from signed_integers;
> [Diff] (-expected|+actual)
> - -NaN 4.60517 -NaN
> - -NaN 9.21034 -NaN
> - 0.69315 -NaN 4.81218
> - 1.38629 NULL NULL
> + 0.69315 NaN 4.81218
> + 1.38629 NULL NULL
> + NaN 4.60517 NaN
> + NaN 9.21034 NaN
> at test_files/scalar.slt:543
>
> Error: Execution("1 failures")
> error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests`
> ```
Same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jonahgao commented on issue #7458: Mismatch in query results in the local machine
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao commented on issue #7458:
URL: https://github.com/apache/arrow-datafusion/issues/7458#issuecomment-1702886615
> Expected -NaN results in the query outputs become NaN in my local tests. What could be the reason for this? As far as I know, there is no -NaN in IEEE 754.
I also think so.
We can accept `+NAN` and `-NAN` as inputs just like PostgreSQL does. However, when outputting, it should no longer differentiate them because `NAN` represents an exception and the sign is no longer meaningful.
```
postgres=# select '+NAN'::float,'+NAN'::float;
float8 | float8
--------+--------
NaN | NaN
(1 row)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jonahgao commented on issue #7458: Mismatch in query results in the local machine
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao commented on issue #7458:
URL: https://github.com/apache/arrow-datafusion/issues/7458#issuecomment-1702818797
It should be related to #7403.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #7458: Mismatch in query results in the local machine
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #7458: Mismatch in query results in the local machine
URL: https://github.com/apache/arrow-datafusion/issues/7458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org