svn commit: r1056206 - in /hadoop/hdfs/trunk: CHANGES.txt src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java

[to...@apache.org]

Author: todd
Date: Fri Jan  7 06:48:18 2011
New Revision: 1056206

URL: http://svn.apache.org/viewvc?rev=1056206&view=rev
Log:
HDFS-1504. FSImageSaver should catch all exceptions, not just IOE. Contributed by Todd Lipcon

Modified:
    hadoop/hdfs/trunk/CHANGES.txt
    hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java

Modified: hadoop/hdfs/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/CHANGES.txt?rev=1056206&r1=1056205&r2=1056206&view=diff
==============================================================================
--- hadoop/hdfs/trunk/CHANGES.txt (original)
+++ hadoop/hdfs/trunk/CHANGES.txt Fri Jan  7 06:48:18 2011
@@ -481,6 +481,8 @@ Release 0.22.0 - Unreleased
     HDFS-1542. Add test for HADOOP-7082, a deadlock writing Configuration to
     HDFS. (todd)
 
+    HDFS-1504. FSImageSaver should catch all exceptions, not just IOE. (todd)
+
 Release 0.21.1 - Unreleased
 
   IMPROVEMENTS

Modified: hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java?rev=1056206&r1=1056205&r2=1056206&view=diff
==============================================================================
--- hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java (original)
+++ hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java Fri Jan  7 06:48:18 2011
@@ -1139,9 +1139,9 @@ public class FSImage extends Storage {
     public void run() {
       try {
         saveCurrent(sd);
-      } catch (IOException ie) {
-        LOG.error("Unable to save image for " + sd.getRoot(), ie);
-        errorSDs.add(sd);              
+      } catch (Throwable t) {
+        LOG.error("Unable to save image for " + sd.getRoot(), t);
+        errorSDs.add(sd);
       }
     }