Re: [PR] fix: Time Comparison Feature Reverts Metric Labels to Metric Keys in Table Charts [superset]

["geido (via GitHub)" <gi...@apache.org>]

geido commented on code in PR #32665:
URL: https://github.com/apache/superset/pull/32665#discussion_r1995758285


##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -605,6 +605,15 @@ export default function TableChart<D extends DataRecord = DataRecord>(
       // Calculate the number of placeholder columns needed before the current header
       const startPosition = value[0];
       const colSpan = value.length;
+      // Retrieve the originalLabel from the first column in this group
+      const originalLabel = columnsMeta[value[0]]?.originalLabel || key;
+
+      if (!columnsMeta[value[0]]?.originalLabel) {
+        // Use a proper logging function if available
+        console.debug(
+          `originalLabel not found for column at index ${value[0]}, using key as fallback`,
+        );

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org