You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/10/03 01:46:59 UTC

[GitHub] spark pull request #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19370#discussion_r142297093
  
    --- Diff: bin/run-example.cmd ---
    @@ -17,6 +17,13 @@ rem See the License for the specific language governing permissions and
     rem limitations under the License.
     rem
     
    -set SPARK_HOME=%~dp0..
    +rem Figure out where the Spark framework is installed
    +set FIND_SPARK_HOME_SCRIPT=%~dp0find_spark_home.py
    --- End diff --
    
    Shouldn't we change this one too?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org