[GitHub] spark pull request #14314: [SPARK-16678] [SPARK-16677] [SQL] Fix two View-re...

[viirya <gi...@git.apache.org>]

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14314#discussion_r71825974
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
    @@ -105,6 +105,12 @@ case class CreateViewCommand(
           val tableIdentifier = tableDesc.identifier.copy(database = Option(database))
     
           if (sessionState.catalog.tableExists(tableIdentifier)) {
    +        val tableMetadata = sessionState.catalog.getTableMetadata(tableIdentifier)
    +        if (tableMetadata.tableType != CatalogTableType.VIEW) {
    +          throw new AnalysisException(
    --- End diff --
    
    If allowing existing, do we still need to throw this excepion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org