You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (Created) (JIRA)" <ji...@apache.org> on 2012/04/07 01:52:17 UTC
[jira] [Created] (HBASE-5744) Thrift server metrics should be long
instead of int
Thrift server metrics should be long instead of int
---------------------------------------------------
Key: HBASE-5744
URL: https://issues.apache.org/jira/browse/HBASE-5744
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Priority: Minor
As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249521#comment-13249521 ]
Phabricator commented on HBASE-5744:
------------------------------------
mbautin has committed the revision "[jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of int".
REVISION DETAIL
https://reviews.facebook.net/D2679
COMMIT
https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1310973
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5744) Thrift server metrics should be long
instead of int
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5744:
-------------------------------
Attachment: D2685.2.patch
mbautin updated the revision "[jira] [HBASE-5744] Thrift server metrics should be long instead of int".
Reviewers: stack, sc, Kannan, JIRA
Removing the old unused overload of verifyMetrics.
REVISION DETAIL
https://reviews.facebook.net/D2685
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249460#comment-13249460 ]
Phabricator commented on HBASE-5744:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of int".
Scott: thanks for reviewing!
Stack: yes, I will post a trunk patch in a bit.
REVISION DETAIL
https://reviews.facebook.net/D2679
BRANCH
thrift_server_metrics_should_be_long_HBASE-5744_v2
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5744) Thrift server metrics should be long
instead of int
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5744:
-------------------------------
Attachment: D2685.3.patch
mbautin updated the revision "[jira] [HBASE-5744] Thrift server metrics should be long instead of int".
Reviewers: stack, sc, Kannan, JIRA
Submitted incomplete diff last time, adding other changes.
REVISION DETAIL
https://reviews.facebook.net/D2685
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, D2685.3.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249467#comment-13249467 ]
Phabricator commented on HBASE-5744:
------------------------------------
sc has accepted the revision "[jira] [HBASE-5744] Thrift server metrics should be long instead of int".
+1 Thanks for fixing the trunk!
REVISION DETAIL
https://reviews.facebook.net/D2685
BRANCH
thrift_server_metrics_should_be_long_HBASE-5744_v2
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250007#comment-13250007 ]
Phabricator commented on HBASE-5744:
------------------------------------
mbautin has abandoned the revision "[jira] [HBASE-5744] Thrift server metrics should be long instead of int".
Unfortunately, I committed this diff under the 89-fb differential revision first (D2679) and had to edit the commit message. Here is what I did:
> svn propedit -r 1311167 --revprop svn:log
The new commit message is as follows:
> svn log -r1311167 https://svn.apache.org/repos/asf/hbase/trunk
------------------------------------------------------------------------
r1311167 | mbautin | 2012-04-09 02:00:11 -0700 (Mon, 09 Apr 2012) | 23 lines
[jira] [HBASE-5744] Thrift server metrics should be long instead of int
Summary:
As we measure our Thrift call latencies in nanoseconds, we need to make
latencies long instead of int everywhere. There is a bug where we truncate a
nanosecond latency to int, which is a problem with RPCs that take more than
2.147483647 seconds to process.
This is a trunk diff. The 89-fb version of this diff is at D2679.
Test Plan:
TestThriftServer is updated to test for the failure case (an RPC is artificially
made to take 3 seconds). The new test case fails without the fix.
Re-run all unit tests.
Reviewers: stack, sc, Kannan, JIRA
Reviewed By: sc
Differential Revision: https://reviews.facebook.net/D2685
If you have a git-svn checkout that got confused by this, here is how to get it back to a consistent state:
git svn reset 1311166
git svn rebase
Sorry about the inconvenience.
REVISION DETAIL
https://reviews.facebook.net/D2685
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, D2685.3.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5744) Thrift server metrics should be long
instead of int
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5744:
-------------------------------
Attachment: D2685.1.patch
mbautin requested code review of "[jira] [HBASE-5744] Thrift server metrics should be long instead of int".
Reviewers: stack, sc, Kannan, JIRA
As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere. There is a bug where we truncate a nanosecond latency to int, which is a problem with RPCs that take more than 2.147483647 seconds to process.
This is a trunk diff. The 89-fb version of this diff is at D2679.
TEST PLAN
TestThriftServer is updated to test for the failure case (an RPC is artificially made to take 3 seconds). The new test case fails without the fix.
Re-run all unit tests.
REVISION DETAIL
https://reviews.facebook.net/D2685
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6153/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249407#comment-13249407 ]
Phabricator commented on HBASE-5744:
------------------------------------
stack has commented on the revision "[jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of int".
lgtm. Do we need this on trunk too MIkhail?
REVISION DETAIL
https://reviews.facebook.net/D2679
BRANCH
thrift_server_metrics_should_be_long_HBASE-5744_v2
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5744) Thrift server metrics should be long
instead of int
Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HBASE-5744:
----------------------------------
Assignee: Mikhail Bautin
Status: Patch Available (was: Open)
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5744) Thrift server metrics should be long
instead of int
Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HBASE-5744:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk.
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, D2685.3.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249744#comment-13249744 ]
Hadoop QA commented on HBASE-5744:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521924/D2685.3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1452//console
This message is automatically generated.
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, D2685.3.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249144#comment-13249144 ]
Phabricator commented on HBASE-5744:
------------------------------------
sc has accepted the revision "[jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of int".
Looks good to me. Thanks a lot for the fix!
REVISION DETAIL
https://reviews.facebook.net/D2679
BRANCH
thrift_server_metrics_should_be_long_HBASE-5744_v2
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249479#comment-13249479 ]
Hadoop QA commented on HBASE-5744:
----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521874/jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1447//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1447//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1447//console
This message is automatically generated.
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5744) Thrift server metrics should be long
instead of int
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5744:
-------------------------------
Attachment: D2679.1.patch
mbautin requested code review of "[jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of int".
Reviewers: sc, dhruba, Kannan, Liyin, JIRA
As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere. There is a bug where we truncate a nanosecond latency to int, which is a problem with RPCs that take more than 2.147483647 seconds to process.
TEST PLAN
TestThriftServer is updated to test for the failure case (an RPC is artificially made to take 3 seconds). The new test case fails without the fix.
Re-run all unit tests.
REVISION DETAIL
https://reviews.facebook.net/D2679
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6135/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249470#comment-13249470 ]
Hadoop QA commented on HBASE-5744:
----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521872/D2685.1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1446//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1446//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1446//console
This message is automatically generated.
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249756#comment-13249756 ]
Hudson commented on HBASE-5744:
-------------------------------
Integrated in HBase-TRUNK #2729 (See [https://builds.apache.org/job/HBase-TRUNK/2729/])
[jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of int
Summary: As we measure our Thrift call latencies in nanoseconds, we need to make
latencies long instead of int everywhere. There is a bug where we truncate a
nanosecond latency to int, which is a problem with RPCs that take more than
2.147483647 seconds to process.
Test Plan:
TestThriftServer is updated to test for the failure case (an RPC is artificially
made to take 3 seconds). The new test case fails without the fix.
Re-run all unit tests.
Reviewers: sc, dhruba, Kannan, Liyin, JIRA
Reviewed By: sc
CC: stack
Differential Revision: https://reviews.facebook.net/D2679 (Revision 1311167)
Result = SUCCESS
mbautin :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, D2685.3.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5744) Thrift server metrics should be
long instead of int
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249937#comment-13249937 ]
Hudson commented on HBASE-5744:
-------------------------------
Integrated in HBase-TRUNK-security #164 (See [https://builds.apache.org/job/HBase-TRUNK-security/164/])
[jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of int
Summary: As we measure our Thrift call latencies in nanoseconds, we need to make
latencies long instead of int everywhere. There is a bug where we truncate a
nanosecond latency to int, which is a problem with RPCs that take more than
2.147483647 seconds to process.
Test Plan:
TestThriftServer is updated to test for the failure case (an RPC is artificially
made to take 3 seconds). The new test case fails without the fix.
Re-run all unit tests.
Reviewers: sc, dhruba, Kannan, Liyin, JIRA
Reviewed By: sc
CC: stack
Differential Revision: https://reviews.facebook.net/D2679 (Revision 1311167)
Result = FAILURE
mbautin :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, D2685.3.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5744) Thrift server metrics should be long
instead of int
Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HBASE-5744:
----------------------------------
Attachment: jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
The same patch (re-attaching to run a test on Jenkins).
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira