You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2012/05/27 21:05:22 UTC
[jira] [Created] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Andrew Purtell created HBASE-6114:
-------------------------------------
Summary: CacheControl flags should be tunable per table schema per CF
Key: HBASE-6114
URL: https://issues.apache.org/jira/browse/HBASE-6114
Project: HBase
Issue Type: Improvement
Reporter: Andrew Purtell
CacheControl flags should be tunable per table schema per CF, especially
hbase.rs.cacheblocksonwrite, also hfile.block.index.cacheonwrite, io.storefile.bloom.cacheonwrite.
It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285076#comment-13285076 ]
stack commented on HBASE-6114:
------------------------------
Just going by javabean convention for methods that return boolean.... E.g. http://docstore.mik.ua/orelly/java-ent/jnut/ch06_02.htm
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285524#comment-13285524 ]
Hudson commented on HBASE-6114:
-------------------------------
Integrated in HBase-0.92 #431 (See [https://builds.apache.org/job/HBase-0.92/431/])
HBASE-6114. CacheControl flags should be tunable per table schema per CF (Revision 1344107)
Result = SUCCESS
apurtell :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell reassigned HBASE-6114:
-------------------------------------
Assignee: Andrew Purtell
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285357#comment-13285357 ]
Hadoop QA commented on HBASE-6114:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530143/6114-0.92-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2045//console
This message is automatically generated.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Status: Open (was: Patch Available)
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285605#comment-13285605 ]
Hudson commented on HBASE-6114:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #32 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/32/])
HBASE-6114. CacheControl flags should be tunable per table schema per CF (Revision 1344105)
Result = FAILURE
apurtell :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285356#comment-13285356 ]
Andrew Purtell commented on HBASE-6114:
---------------------------------------
bq. Since TestCacheOnWrite is in io.hfile package, can TestCacheOnWriteInSchema be placed in the same package ?
I chose to put it in regionserver because it operates at the Store level, with schema details. It makes more sense here IMO, even though the second part of the test cares only about HFile blocks.
bq. That way getOnDiskSizeWithHeader() can be made package private.
This is a trivial change and the related methods are all public. Do you have an objection?
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285389#comment-13285389 ]
Hadoop QA commented on HBASE-6114:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530155/6114.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2047//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2047//console
This message is automatically generated.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285350#comment-13285350 ]
Zhihong Yu commented on HBASE-6114:
-----------------------------------
{code}
+ * Copyright 2011 The Apache Software Foundation
{code}
Year is not needed.
Since TestCacheOnWrite is in io.hfile package, can TestCacheOnWriteInSchema be placed in the same package ?
That way getOnDiskSizeWithHeader() can be made package private.
Please submit patch for Hadoop QA.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Status: Patch Available (was: Open)
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Comment: was deleted
(was: -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530143/6114-0.92-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2045//console
This message is automatically generated.)
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Description:
CacheControl flags should be tunable per table schema per CF, especially
cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
was:
CacheControl flags should be tunable per table schema per CF, especially
hbase.rs.cacheblocksonwrite, also hfile.block.index.cacheonwrite, io.storefile.bloom.cacheonwrite.
It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
Fix Version/s: 0.94.1
0.96.0
0.92.2
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287190#comment-13287190 ]
Hudson commented on HBASE-6114:
-------------------------------
Integrated in HBase-0.94-security #33 (See [https://builds.apache.org/job/HBase-0.94-security/33/])
HBASE-6114. CacheControl flags should be tunable per table schema per CF (Revision 1344106)
Result = FAILURE
apurtell :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.94.1
0.96.0
0.92.2
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Hadoop QA result contains an unrelated timeout/failure. All tests pass locally. Failed test in report passes locally. New unit test passes locally. Committed to trunk, 0.94, and 0.92 branches. Thanks for the reviews and comments Stack and Ted.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Attachment: 6114-0.92-v2.patch
6114-0.94-v2.patch
6114-trunk-v2.patch
v2 patches include a unit test that constructs a Store and then does something very similar to io.hfile.TestCacheOnWrite, using Readers and Writers created by the Store. Updated patches are for review because I changed the visibility of Store#createWriterInTmp and HFileBlock#getOnDiskSizeWithHeader, depending on branch. Will commit in a few hours if no comment, as an implicit ack.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285225#comment-13285225 ]
Andrew Purtell commented on HBASE-6114:
---------------------------------------
bq. Maybe just commit what you have then Andrew if it is keeping the pattern set elsewhere in this class?
Thanks, I do think HCM and CacheConfig should have the same convention for asking the same question. Will commit in a few minutes the attached patches with Ted's comment change and HCD#shouldCacheIndexOnWrite renamed to HCD#shouldCacheIndexesOnWrite.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284262#comment-13284262 ]
Zhihong Yu commented on HBASE-6114:
-----------------------------------
Patch looks good.
{code}
+ * Default setting for whether to cache index data blocks on write if block
{code}
'data' should be removed.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285208#comment-13285208 ]
stack commented on HBASE-6114:
------------------------------
bq. What about existing methods like CacheConfig#shouldCacheDataOnRead and CacheConfig#shouldCacheBlockOnRead? Change those too?
Ugh. Who let those in!
Maybe just commit what you have then Andrew if it is keeping the pattern set elsewhere in this class?
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285058#comment-13285058 ]
Andrew Purtell commented on HBASE-6114:
---------------------------------------
bq. Change shouldCacheDataOnWrite to isCacheDataOnWrite on commit and same for all other should methods.
Ick, but you're the boss. :-)
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285359#comment-13285359 ]
Zhihong Yu commented on HBASE-6114:
-----------------------------------
getOnDiskSizeWithoutHeader() is public. I am fine with making another method public.
Pass from Hadoop QA is desirable.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-6114.
--------------------------------
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.94.1, 0.96.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.2, 0.94.1, 0.96.0
>
> Attachments: 6114-0.92.patch, 6114-0.92-v2.patch, 6114-0.94.patch, 6114-0.94-v2.patch, 6114.patch, 6114-trunk.patch, 6114-trunk-v2.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Affects Version/s: 0.94.1
0.96.0
0.92.2
Fix Version/s: (was: 0.94.1)
(was: 0.96.0)
(was: 0.92.2)
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285132#comment-13285132 ]
Andrew Purtell edited comment on HBASE-6114 at 5/29/12 9:16 PM:
----------------------------------------------------------------
bq. Just going by javabean convention for methods that return boolean....
What about existing methods like CacheConfig#shouldCacheDataOnRead and CacheConfig#shouldCacheBlockOnRead? Change those too?
Edit: Related, HCD#shouldCacheIndexOnWrite probably should be be HCD#shouldCacheIndexesOnWrite because we have CacheConfig#shouldCacheIndexesOnWrite.
was (Author: apurtell):
bq. Just going by javabean convention for methods that return boolean....
What about existing methods like CacheConfig#shouldCacheDataOnRead and CacheConfig#shouldCacheBlockOnRead? Change those too?
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287252#comment-13287252 ]
Hudson commented on HBASE-6114:
-------------------------------
Integrated in HBase-0.92-security #109 (See [https://builds.apache.org/job/HBase-0.92-security/109/])
HBASE-6114. CacheControl flags should be tunable per table schema per CF (Revision 1344107)
Result = SUCCESS
apurtell :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285441#comment-13285441 ]
Hudson commented on HBASE-6114:
-------------------------------
Integrated in HBase-0.94 #229 (See [https://builds.apache.org/job/HBase-0.94/229/])
HBASE-6114. CacheControl flags should be tunable per table schema per CF (Revision 1344106)
Result = FAILURE
apurtell :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285437#comment-13285437 ]
Hudson commented on HBASE-6114:
-------------------------------
Integrated in HBase-TRUNK #2952 (See [https://builds.apache.org/job/HBase-TRUNK/2952/])
HBASE-6114. CacheControl flags should be tunable per table schema per CF (Revision 1344105)
Result = SUCCESS
apurtell :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285030#comment-13285030 ]
stack commented on HBASE-6114:
------------------------------
+1 on patch
Change shouldCacheDataOnWrite to isCacheDataOnWrite on commit and same for all other should methods.
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6114) CacheControl flags should be
tunable per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285132#comment-13285132 ]
Andrew Purtell commented on HBASE-6114:
---------------------------------------
bq. Just going by javabean convention for methods that return boolean....
What about existing methods like CacheConfig#shouldCacheDataOnRead and CacheConfig#shouldCacheBlockOnRead? Change those too?
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Status: Patch Available (was: Open)
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Attachment: 6114-0.92.patch
6114-0.94.patch
6114-trunk.patch
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Attachments: 6114-0.92.patch, 6114-0.94.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6114) CacheControl flags should be tunable
per table schema per CF
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6114:
----------------------------------
Attachment: 6114.patch
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
> Key: HBASE-6114
> URL: https://issues.apache.org/jira/browse/HBASE-6114
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch, 6114.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor family) to construct the CacheConfig, so it's a simple change there to override configuration properties with values of table schema attributes if present.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira