You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/15 06:26:04 UTC

[GitHub] [flink] zentol opened a new pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

zentol opened a new pull request #16159:
URL: https://github.com/apache/flink/pull/16159


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16159:
URL: https://github.com/apache/flink/pull/16159#issuecomment-861214607


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48 (Thu Sep 23 17:27:24 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16159:
URL: https://github.com/apache/flink/pull/16159#issuecomment-861241710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18981",
       "triggerID" : "c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18981) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] XComp commented on pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #16159:
URL: https://github.com/apache/flink/pull/16159#issuecomment-866650265


   Ok, thanks for clarification. 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16159:
URL: https://github.com/apache/flink/pull/16159#issuecomment-861214607


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48 (Tue Jun 15 06:30:10 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol commented on pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #16159:
URL: https://github.com/apache/flink/pull/16159#issuecomment-866623285


   Other cases are handled in other tickets. All the classes you listed will be moved to a new flink-rpc-akka module, either completely or partially.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16159:
URL: https://github.com/apache/flink/pull/16159#issuecomment-861241710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol merged pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #16159:
URL: https://github.com/apache/flink/pull/16159


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16159: [FLINK-22991][network] Use Optional in NettyBufferPool

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16159:
URL: https://github.com/apache/flink/pull/16159#issuecomment-861241710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18981",
       "triggerID" : "c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c839a938cb86cd7e8176fffcae8c9c7d2ba9ba48 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18981) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org